October 2016 - Koha-bugs - lists.koha-community.org

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55420|0 |1 is obsolete| | --- Comment #87 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Created attachment 56427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56427&action=ed… Bug 13321: Fix unitprice rounding We need to display the rounded value, but insert the exact value. The unit price can be change on receiving, so the input value can be modified. But if it's not, we must insert the exact (not rounded) unit price, which is the ecost value. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55419|0 |1 is obsolete| | --- Comment #86 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Created attachment 56426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56426&action=ed… Bug 13321: Csv export - Display rrp and ecost with and without taxes If a basketgroup is exported as a CSV file, both prices should be displayed to avoid confusion. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55418|0 |1 is obsolete| | --- Comment #85 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Created attachment 56425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56425&action=ed… Bug 13321: Tax and prices calculation - DB Changes This patch adds 7 columns to the aqorders table: * unitprice_tax_excluded * unitprice_tax_included * rrp_tax_excluded * rrp_tax_included * ecost_tax_excluded * ecost_tax_included * tax_value It also renames: * aqorders.gstrate with aqorders.tax_rate * aqbooksellers.gstrate with aqbooksellers.tax_rate The new columns are filled with the previous calculation method. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55417|0 |1 is obsolete| | --- Comment #84 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Created attachment 56424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56424&action=ed… Bug 13321: Fix the prices calculation method Well, we have finally arrived here \o/ The method where the prices are calculated uses the equations listed on the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC) The ecost is calculated from the rrp (using the discount and the tax rate). That's why we removed the ability to edit this value. That's why we remove the ability to edit the ecost on ordering in a previous commit (bug 12840). The total is now calculated in the scripts. That's why this patch removes lines in the test file. In C4::Acquisition::populate_order_with_prices, the calculation on receiving must depend on the 'invoiceincgst' supplier parameter, and not listincgst (which is used on ordering). It also removes the rounding errors, now we store "exact" values in DB (10^-6). The values will be displayed using the Price TT plugin it will round the values for us. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55416|0 |1 is obsolete| | --- Comment #83 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Created attachment 56423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56423&action=ed… Bug 13321: use the populate_with_prices where needed Now we need to calculate the prices (ecost, rrp, unitprice) and tax (tax_rate, tax_value) when the price is set for an order. This only appends in the 3 files impacted by this patch. addorder*.pl on ordering finishreceive.pl on receiving Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55415|0 |1 is obsolete| | --- Comment #82 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Created attachment 56422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56422&action=ed… Bug 13321: Rename variables This patch renames the variable according to the new DB column names * gste => tax_excluded * gsti => tax_included * gstrate => tax_rate * gstvalue => tax_value This patch also modify the ModReceiveOrder subroutine: * Edit vendor note on receiving is not possible, so the code should not permit that. * Update ModReceiveOrder to pass a hashref And that's all! git grep on gste, gsti, gstrate and gstvalue should not return any code that can be executed. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56389|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15388] Show Syndetics covers by UPC in search results
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan(a)bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the November 16.11 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17094] New: Methods of Koha::Object[s] -based classed should not return DBIx::Class objects
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 Bug ID: 17094 Summary: Methods of Koha::Object[s]-based classed should not return DBIx::Class objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org For instance the 2 methods get_shares and get_contents from Koha::Virtualshelf return DBIx::Class objects instead of Koha::Virtualshelfshares and Koha::Virtualshelfcontents objects. -- You are receiving this mail because: You are watching all bug changes.

1 14