October 2016 - Koha-bugs - lists.koha-community.org

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55867|0 |1 is obsolete| | --- Comment #95 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56359&action=ed… Bug 5670: remove useless call to ->new when ->search is enought Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55866|0 |1 is obsolete| | --- Comment #94 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56358&action=ed… Bug 5670: mv housebound_* to search_housebound_* I think it's better to prefix the subroutine names used to search with 'search_'. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55865|0 |1 is obsolete| | --- Comment #93 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56357&action=ed… Bug 5670: Add the 'required' class to required fields Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55739|0 |1 is obsolete| | --- Comment #92 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56356&action=ed… Bug 5670: [QA Followup] Fix `div.patroninfo`. * members/housebound.pl: Provide full patron hash keys, extended patron attributes & picture to template. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Refactor to use new information. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55738|0 |1 is obsolete| | --- Comment #91 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56355&action=ed… Bug 5670: [QA Followup] Small QA fixes. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove `console.log` invocations. * members/housebound.pl ($houseboundvisits, $chooser, $deliverer): Remove unused variables. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55737|0 |1 is obsolete| | --- Comment #90 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56354&action=ed… Bug 5670: [QA Followup] Housebound link from patron edit. * koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc: Add a link to the housebound module view if it is switched on. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55736|0 |1 is obsolete| | --- Comment #89 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56353&action=ed… Bug 5670: [QA Followup] Avoid CGI::param in list context. * members/housebound.pl: Force `borrowernumber` to scalar context. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55735|0 |1 is obsolete| | --- Comment #88 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56352&action=ed… Bug 5670: [QA Followup] Fix category_type ref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Replace references to `category_type` with `categorycode`. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55734|0 |1 is obsolete| | --- Comment #87 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56351&action=ed… Bug 5670: [QA Followup] Don't force ISO dates. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Use ".datepicker" class for date input, use `$KohaDates` to filter our iso dates. * members/housebound.pl: Use DateTime and Koha::DateUtils to parse incoming date to ISO format. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55336|0 |1 is obsolete| | --- Comment #86 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56350&action=ed… Bug 5670: [Followup] Refactor .pl; error messages. * members/housebound.pl: Refactor & store messages for encountered errors. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Show messages. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0