November 2016 - Koha-bugs - lists.koha-community.org

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 22 Nov '16

22 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to M. Tompsett from comment #18) > (In reply to Jonathan Druart from comment #17) > > Waiting for more QA opinions. > > We never got them. What should we do to get this moving again? Either you fix what I raised or you find someone to agree with your points. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 22 Nov '16

22 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 22 Nov '16

22 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #16 from Nick Clemens <nick(a)bywatersolutions.com> --- I tried testing but this doesn't seem to repair the issue, I am still seeing a random return of one element from the hash, occasionally patron surname firstname or cardnumber -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 21 Nov '16

21 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #32 from M. Tompsett <mtompset(a)hotmail.com> --- I put this to "Needs Signoff" in case, Marc should retest it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 21 Nov '16

21 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54746|0 |1 is obsolete| | --- Comment #31 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 57688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57688&action=ed… Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost Reworking based on output of: git grep "gp\/reader" Additionally, some changes might be in order though gp/reader works. https://affiliate-program.amazon.com/help/topic/t64/a1 suggests using dp A dp was discovered, so that part of the URL was left unchanged. The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}") if defined. TEST PLAN --------- 1) Added: "100 years of Canadian foreign policy / edited by Robert Bothwell and Jean Daudelin." 2) Added a second book with the word foreign in the title. 3) Waited for reindex 4) Checked out the Canadian foreign policy book. 5) Applied patch 6) Made sure that: - AmazonAssocTag was set to TEST (easy to notice) - AmazonCoverImages was set to 'Show' - OPACAmazonCoverImages was set to 'Show' 7) Searched intranet for 'foreign' to find the detail page -- hovering over picture shows URL with ?tag=TEST in it. 8) Went to the OPAC Detail page 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for the picture contained ?tag=TEST in it. 10) Logged into the OPAC 11) Confirmed the URL in the checked out list on your summary page contained ?tag=TEST in it. 12) Confirmed the URL in the checked out list on your reading history page contained ?tag=TEST in it. 13) Confirmed links worked (went to expected page) 14) run koha qa test tools Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 21 Nov '16

21 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 21 Nov '16

21 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #30 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- My research suggests that the ref parameter is not needed - we could remove it and that would also solve the dangling & problem. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 21 Nov '16

21 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #18 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #17) > Waiting for more QA opinions. We never got them. What should we do to get this moving again? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 21 Nov '16

21 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #29 from M. Tompsett <mtompset(a)hotmail.com> --- So, Katrin, how are we fixing this? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7937] Silence warns in OPAC error log (koha-opac-error_log)
by bugzilla-daemon＠bugs.koha-community.org 21 Nov '16

21 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #20 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Marc Véron from comment #19) > Is this patch set still valid? As a general concept, yes, I believe so. These patches specifically? I don't know. -- You are receiving this mail because: You are watching all bug changes.

1 0