November 2016 - Koha-bugs - lists.koha-community.org

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #35 from Josef Moravec <josef.moravec(a)gmail.com> --- I rebased the patches on master and in followup fixed same small issues - we need this in our project. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #34 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 57846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57846&action=ed… Bug 15165: followup - fix definitions, and passing amount parameter in pay method -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56696|0 |1 is obsolete| | --- Comment #33 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 57845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57845&action=ed… Bug 15165 - Add API routes to pay accountlines POST /accountlines/(:accountlines_id)/payment (pay towards accountline) POST /patrons/(:borrowernumber)/payment (pay towards borrower) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You must have permission updatecharges. 2. Create a fine to any patron and get the accountlines_id. 3. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment without body where YYY is the accountlines_id you created in step 2. 4. Check that the accountline that you created in step 2 is paid. 5. Create two payments with amount 5.00 (with no other outstanding payments) 6. Send POST request to http://yourlibrary/api/v1/patrons/ZZZ/payment with body {"amount": 10} Replace ZZZ with the borrowernumber for which you have created two fines 7. Check that the two accountlines are paid. 8. Repeat step 2. 9. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment with body {"amount": XXX} Replace YYY with the accountlines_id you created in step 8. Set amount (XXX) to the half of the amount of the fine you created in step 8. 10. Check that the fine is still outstanding with half of the original amount. 11. Run unit tests at t/db_dependent/api/v1/accountlines.t and t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56695|0 |1 is obsolete| | --- Comment #32 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 57844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57844&action=ed… Bug 15165 - Add API route to edit accountlines PUT /accountlines/{accountlines_id} (edit) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY where YYY is one of your accountlines_id. See the body definition in definitions/editAccountlineBody.json and use this in your PUT request. 3. Run unit tests in t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56694|0 |1 is obsolete| | --- Comment #31 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 57843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57843&action=ed… Bug 15165 - Add API route to list accountlines GET /accountlines (list) GET /accountlines?borrowernumber=X (list) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Go to http://yourlibrary/api/v1/accountlines?borrowernumber=XXX (replace XXX with a borrowernumber that has accountlines) and check you receive correct data 3. Go to http://yourlibrary/api/v1/accountlines and check that you receive all accountlines 4. Run unit tests in t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15897 --- Comment #30 from Josef Moravec <josef.moravec(a)gmail.com> --- Because of the way the Koha::Account->pay is called in the patch, this report depends especially on bug 15897. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 [Bug 15897] Use Koha::Account::pay internally for recordpayment_selectaccts -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17391] New: ReturnpathDefault missing from syspref.sql
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 Bug ID: 17391 Summary: ReturnpathDefault missing from syspref.sql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com ReturnpathDefault and possibly others are missing from sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 11861] Add ISSN column in serials claims table
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11861 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17703 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 [Bug 17703] Add ISSN column in serials claims table - fix -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #6 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '16

30 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #133 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes.

1 0