December 2016 - Koha-bugs - lists.koha-community.org

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '16

26 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #49 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 58429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58429&action=ed… Bug 13757: (followup) Regression tests for ->approve changes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '16

26 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #48 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 58428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58428&action=ed… Bug 13757: (followup) Only touch opac_editable attributes As reported by Owen, the members-update.pl was showing every attributes the patron has (display issue) instead of showing only those affected by the changes. This patch fixes this by filtering the patron's attributes by opac editability. It also fixes Koha::Patron::Modification->approve so it only clears the attributes with the updating 'code' and leaves the others untouched. As its been coded so far (until someone refactors it all) the Koha::Patron::Modification object needs to contain all the attributes for a specific code. And it comes from parsing the UI's input. Tests for Koha::Patron::Modification->approve to come. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '16

23 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41319|0 |1 is obsolete| | --- Comment #38 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 58426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58426&action=ed… Bug12747 - Follow-up to QA Removed unnecessary code in Breeding.pm and provided a new test in Breeding.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '16

23 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41318|0 |1 is obsolete| | --- Comment #37 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 58425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58425&action=ed… Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '16

23 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41317|0 |1 is obsolete| | --- Comment #36 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 58424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58424&action=ed… Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches together, followed test plan, works as expected Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '16

23 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '16

23 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58418&action=ed… Bug 14637: Followup - Fix number of tests due to rebase Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '16

23 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58417&action=ed… Bug 14637: Fix add patron category under MySQL 5.7 If no dateofbirthrequired or upperagelimit is set on the interface, the ->store method will receive an empty string defined for these values. For INT field, we must explicitely set these empty value to undef instead to avoid MySQL 5.7 (and strict mode) to raise: DBD::mysql::st execute failed: Incorrect integer value: ' for column 'dateofbirthrequired'' Test plan: Using MySQL 5.7 (and/or sql_mode=STRICT_TRANS_TABLES) Create a patron category without specifying upperagelimit or dateofbirthrequired Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '16

23 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56675|0 |1 is obsolete| | Attachment #56676|0 |1 is obsolete| | Attachment #56677|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58416&action=ed… Bug 14637: Fix add patron category under MySQL 5.7 - tests Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '16

23 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0