December 2016 - Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58202|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58391&action=ed… Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- All in all I like what you are proposing! Can you add a followup for your suggestions? (In reply to Owen Leonard from comment #14) > Created attachment 58159 [details] > Proposal for initial state of add guarantor form > > It seems that now the search for patrons to select as a guarantor includes > patrons with a 'Child' type patron category. Is that intentional? Shouldn't > they be excluded? > > I notice also that when you select a patron to be a guarantor, the patron > number is no longer a link to the patron record. I think it would make more > sense to not show the borrowernumber at all, but make the guarantor name a > link: > > <a href="moredetail.pl?borrowernumber=0000">Surname, Firstname > (cardnumber)</a> > > I think it's confusing that there are two buttons, 'Add guarantor', 'Set to > patron.' They could potentially mean the same thing. I think we might have > the initial state of this form have only two links: 'Search to add > guarantor' and 'Add guarantor manually' (see attached image). > > Clicking the 'Add manually' link would display the form along with a submit > button, and the "Clear" link would be shown. > > The manual add form should prevent the user from submitting empty data. > > Sorry, I know that's a lot, and I'm willing to help with follow-ups if folks > think these are good ideas. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #49 from Lari Taskula <lari.taskula(a)jns.fi> --- (In reply to Lari Taskula from comment #48) > Created attachment 58387 [details] [review] This patch only changes Koha::Issues to Koha::Checkouts. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56506|0 |1 is obsolete| | --- Comment #48 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 58387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58387&action=ed… Bug 13895: Add API routes for checkouts retrieval and renewal GET /checkouts?borrowernumber={borrowernumber} GET /checkouts/{checkout_id} PUT /checkouts/{checkout_id} + unit tests in t/db_dependent/api/v1/checkouts.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with a borrowernumber that has checkouts) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error) 5. Run unit tests in t/db_dependent/api/v1/checkouts.t Depends on bugs 16699 and 14868 Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Lari Taskula <larit(a)student.uef.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] bulkmarcimport.pl reports inserted records twice
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas(a)gmail.com --- Comment #1 from David Gustafsson <glasklas(a)gmail.com> --- The second line is for an inserted item i believe. But should be reported as such. Currently looking into this script and have fixed this in my local branch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14264] Export of CSV from late orders form does only work in English
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This is broken again - see bug 17795. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #60 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58379&action=ed… Bug 12904 - Update template css and js file references -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54488|0 |1 is obsolete| | Attachment #54489|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 58378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58378&action=ed… Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15503] Grab Item Information from Order Files
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #53 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Matthias Meusburger from comment #50) > Hi, > > I couldn't reproduce any of the problems you mentioned on my Unimarc > instance, so I ended up setting up a MARC21 instance using your values for > the syspref and your marc files, and... I couldn't reproduce any of the > problems (see screen captures), except one: > > BOOKBAG itype is indeed not automatically selected, but this is because > there is a trailing space in the BOOKBAG 975$c in your MARC file. > > I don't know if Koha should assume that a trailing space in a field is > irrelevant and remove it, but the fact is that they are not technically > equal. So, no pre-selection. I would agree with that. Koha shouldn't munge the data. If there is a trailing space it should be dealt with preferably at the source. A couple other possibilities would be to use a Marc Modification Template or a plugin to clean up the records. We shouldn't have magic side effects in Koha. Those types of things lead to confusion. The next library might rely on a trailing space and have no idea why it's not working ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4042] Public OPAC search can fall prey to web crawlers
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '16

22 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042 José Anjos <joseanjos(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseanjos(a)gmail.com --- Comment #6 from José Anjos <joseanjos(a)gmail.com> --- I added file robots.txt to /usr/share/koha/opac/htdocs, but makes no difference. I've try it too on /usr/share/koha/opac/htdocs/opac-tmpl but problem persists. I have non stop requests from SemrushBot, AhrefsBot and Google. Server is getting high CPU usage and out of memory every 2/3 days I want to kill that bots... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0