December 2016 - Koha-bugs - lists.koha-community.org

[Bug 16815] New: API routes to list, create, update, delete holds need permissions
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Bug ID: 16815 Summary: API routes to list, create, update, delete holds need permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The REST api for holds CRUD should require hold permissions! I think it needs reserveforothers and it's subpermissions implemented. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 7172] Omnibus for Plack variable scoping problems
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Zeno Tajoli <z.tajoli(a)cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 [Bug 17775] blocker of bug 7172 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Michael Davis <m.r.davis(a)me.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|m.r.davis(a)me.com | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55964|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 58173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58173&action=ed… Bug 6782 - Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions). Currently the card number is generated when the user enters the patron creation form. This creates a problem of concurrency - when two or more simulataneous users are registering members, the error "card no. in use" can occur. This change moves the card number generation to occur after the "Save" button is pressed. Changes: -C4/Members.pm: Added code to fixup_cardnumber,If the cardnumber is blank and "autoMemberNum" ON. -koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Added code to display "leave blank for auto calc during registration" in cardnumber label in patron registration form only if "autoMemberNum" ON. -members/memberentry.pl: Added code to get weather or not "autoMemberNum" is on or off and removed fixup_cardnumber generation. Test cases: -If "autoMemberNum" ON: ->In blank case, must generate auto card number in simulataneous users. ->If user entered, check for unique card number. -If "autoMemberNum" OFF: Must work normal. Followed test plan, works as expected. Note: Syspref PorrowerMandatoryField must not include cardnumber, otherwise you can not save. Maybe that should be mentioned in the comment for syspref autoMemberNum. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13029] Allow to pass additional parameters to SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 58172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58172&action=ed… Bug 13029 : Follow up Adding POD, changing the config files to live in a path pointed to by koha-conf.xml This means multiple instances can have their own config Please test the 2 patches together Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Works as advertised. Arbitrary arguments can be passed to SMS:Send drivers. If an argument is provided that has already been set by SMS::Send or the driver, it will be overwritten by the value from the YAML file. My only suggestion for an improvement would be an example of what the YAML should look like, but that is a minor thing. Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13029] Allow to pass additional parameters to SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56113|0 |1 is obsolete| | Attachment #56116|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 58170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58170&action=ed… Bug 13029: Allow to pass additional parameters to SMS::Send drivers C4::SMS::send_sms now reads a YAML file and pass all parameters in the file to SMS::Send::new. The config file is read in <installdir>/etc/sms/driver/<driver>.yaml. For instance, if the driver used is SMS::Send::UK::Kapow, the config file has to be in <installdir>/etc/sms/driver/UK/Kapow.yaml A underscore character is prepended to all parameter names so they are treated as driver-specific options (leading underscore must not appear in config file). Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13029] Allow to pass additional parameters to SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17419] New: Fix more confusion between smsalertnumber and mobile
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Bug ID: 17419 Summary: Fix more confusion between smsalertnumber and mobile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com members/moremember.pl will set mobile number as smsalertnumber in template if smsalertnumber is not defined. This will cause incorrect display for SMS number in patron's Details-tab. This confusion between smsalertnumber and mobile is already fixed in Bug 14683, but members/moremember.pl was not fixed yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '16

14 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com --- Comment #7 from Mason James <mtj(a)kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.

1 0