February 2016 - Koha-bugs - lists.koha-community.org

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47814|0 |1 is obsolete| | --- Comment #92 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48028&action=ed… [SIGNED-OFF] Bug 9021 [QA Followup] - Use TT plugin instead of passing syspref via script NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47339|0 |1 is obsolete| | --- Comment #91 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48027&action=ed… [SIGNED-OFF] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> NOTE: Rechecked Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47338|0 |1 is obsolete| | --- Comment #90 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48026&action=ed… [SIGNED-OFF] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47133|0 |1 is obsolete| | --- Comment #89 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48025&action=ed… [SIGNED-OFF] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber(a)messaging.sprintpcs.com Verizon phonenumber(a)vtext.com T-Mobile phonenumber(a)tmomail.net AT&T phonenumber(a)txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #88 from M. Tompsett <mtompset(a)hotmail.com> --- Multi-commit bugs are a pain to get through. Thanks for the effort, Kyle. Applies cleanly. Affected test files run. Pretty color use. :) A nice simple elegance to the SMS Provider list. Thanks for the follow up about the additional message. I'll let QA argue over the exact wording. This works well! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #87 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48024&action=ed… Bug 9021 [QA Followup] - Add additional message to deletion warning if provider is in use. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #39 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48020&action=ed… Bug 15632 [QA Followup] - Change method type to _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #23 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48019&action=ed… Bug 15446 [QA Followup] - Update new classes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #38 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48018&action=ed… Bug 15632 [QA Followup] - Undo changes needed for Bug 13618 which was reverted -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #37 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48017&action=ed… Bug 15632 [QA Followup] - Get rid of use of uninitialized value errors for unit tests * Set $user to "" if not passed * Tidy sub -- You are receiving this mail because: You are watching all bug changes.

1 0