February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #36 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48016&action=ed… Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #35 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48015&action=ed… Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #34 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48014&action=ed… Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #33 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48013&action=ed… Bug 15632: Koha::Patron::Messages - Remove GetMessagesCount The GetMessageCount subroutine was only used once, in opac-user.pl, to know if some messages will be displayed. Test plan: 1/ Create messages to display at the OPAC for a patron 2/ Logged this patron in at the OPAC, you should see the messages displayed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #32 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48012&action=ed… Bug 15632: Koha::Patron::Messages - Remove DeleteMessage The DeleteMessage just deleted and logged if needed. This is now be done by Koha::Patron::Message->delete. Test plan: 1/ Go on the "check out" page of a patron 2/ Delete some messages Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #31 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48011&action=ed… Bug 15632: Koha::Patron::Messages - Remove AddMessage The AddMessage subroutine just 1. checked if all the parameters were passed 2. inserted the message in the DB 3. logged the action if needed These 3 jobs are now done by the overloaded store method of Koha::Patron::Message. Test plan: 1/ Go on the "check out" page of a patron 2/ Add different new messages Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #30 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48010&action=ed… Bug 15632: Koha::Patron::Messages - Be sure add and delete will log If the pref BorrowersLog is on, the store and delete method should log into the action_logs table. Easy to do by overloading them. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48004|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48009&action=ed… Bug 15632: Koha::Patron::Messages - Add new classes The following 4 CRUD subroutines in C4::Members: - AddMessage - DeleteMessage - GetMessagesCount - GetMessages could be replaced with a new package based on Koha::Objets. This patchset will add the 2 Koha::Patron::Message[s] classes, then use it to replace the different calls to these subroutine. It will slightly reduce the size of C4::Members Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #22 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48008&action=ed… Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type Some occurrences have been pushed in the meantime. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48007&action=ed… Bug 15446: Update systempreferences rows where type=YesNo and value='' Signed-off-by: Marc Véron <veron(a)veron.ch> Amended to fix typo in sql statement. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0