February 2016 - Koha-bugs - lists.koha-community.org

[Bug 13527] Mixed content warnings in results and detail with Google images on https
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- *** This bug has been marked as a duplicate of bug 14523 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12239] Errors loading script under https in chrome
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12239 --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- Is this bug still valid? I don't see any errors when I look at our OPAC in Chrome. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Patch doesn't apply |Needs Signoff --- Comment #37 from M. Tompsett <mtompset(a)hotmail.com> --- Except for moving the $op line, this is a rebase, which applies. I have not signed off. The sign off change is identical, so I left it marked as such. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42621|0 |1 is obsolete| | --- Comment #36 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 47565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47565&action=ed… Bug 12426: Allow resend for sent messages This patch allows to resend both sent and failed messages. With messages in 'sent' status, we have to be careful not to accidentally send sent messages again. With the previous patch using GET request, this was likely to happen because of browser storing the GET parameters. This patch changes request method from GET to POST. Instead of a simple link, we now have a form element. In notices.pl we redirect back to notices.pl, because with POST there is a risk of resending the message accidentally by form resubmission at refresh. To test, find/create a Patron that has sent or failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the sent or failed message 4. Observe that there is nothing for resending the sent or failed message 5. Apply the patches. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42512|0 |1 is obsolete| | --- Comment #35 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 47564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47564&action=ed… Bug 12426: Simplify the code adding a new subroutine GetMessage The C4::Letters module does not have a GetMessage subroutine, which could be quite useful. This patch adds it and simplifies the code added by the previous patch. It also adds a few tests and fixes POD typos. Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42418|0 |1 is obsolete| | --- Comment #34 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 47563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47563&action=ed… [Signed-off] Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch --- Comment #14 from Marc Véron <veron(a)veron.ch> --- I get an error in circ/del_message.pl line 26: Can't locate Koha/Patrons/Messages.pm in @INC (@INC contains: /usr/share/kohaclone /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /usr/share/kohaclone/circ/del_message.pl line 26. BEGIN failed--compilation aborted at /usr/share/kohaclone/circ/del_message.pl line 26. The line should read use Koha::Patron::Messages; ( instead of use Koha::Patrons::Messages; ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14849] Owner should be FK in uploaded_files
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14849] Owner should be FK in uploaded_files
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Need to think about it (merge deletedborrowers with borrowers table). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Need to think about it (merge deletedborrowers with borrowers table). -- You are receiving this mail because: You are watching all bug changes.

1 0