February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45420|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47550&action=ed… Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set If ExpireReservesMaxPickUpDelay is enabled, the "holds over" tab becomes useless. It would be nice if the "holds over" tab would display *tomorrow's* "holds over" so the librarian can see what will be automatically canceled over night. Test Plan: 1) Apply this patch 2) Enable ExpireReservesMaxPickUpDelay 3) Note the "holds over" list now displays holds that will have been waiting more than the number of days defined in ReservesMaxPickUpDelay as of tomorrow. Signed-off-by: Jason Burds <JBurds(a)dubuque.lib.ia.us> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47507|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron(a)veron.ch> --- Created attachment 47549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47549&action=ed… Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar This patch replaces the email address text overflow solution implemented by Bug 3256 with a CSS3 technique: text-overflow: ellipsis https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow To test, apply the patch and clear your browser cache. Edit the primary email address of a patron so that it is very long. View that patron in the staff client (on the checkout or details page, for instance) and confirm that the email address is truncated with "..." Confirm that the link and the title attribute of the link contain the correct, full email address. Revision uses a percentage instead of a fixed width for email display in the sidebar to accommodate varying sidebar widths. Also added: Handling of all email addresses displayed on the patron detail page. Although email addresses in the body of that page were not in the scope of the original patch, it's a good improvement to include those as well. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14244] viewing a bib item's circ history requires circulation permissions
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |katrin.fischer(a)bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #9 from bondiurbano <costalc(a)gmail.com> --- (In reply to Holger Meißner from comment #8) > (In reply to bondiurbano from comment #2) > > "No renewal before" is an optional setting so it could be absent in the > > rule. > > Yes, but bug 14101 introduced a fallback. If the setting is absent (undef) > then automatic renewal works just like "No renewal before" was zero. Do you > get different results with undef and zero?? > > > Automatic_renewals.pl must be executed BEFORE the item date_due > > expires. > I think this cannot be done with a cron job running just once or a few times > per day. Due date might be any time of the day, especially with hourly loans. > > > Otherwise it will be a due item and so OverduesBlockRenewing will > > block it. > Yes, but I suppose that is exactly what should happen, if the patron has > both automatic and manual loans and some of the manual loans are overdue? > > But I see the problem! It should renew if ONLY automatic renewals are > overdue! So maybe that's the solution. Check if all overdue loans are > automatic, then override the block? > > I need to think about it some more, but does think this makes sense? :) Hi Holger! I will check the fallback. Give a couple of days...I think that the fallback definition is right. But I will check. Meanwhile you can see my attached PDF. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15108] OAI-PMH provider improvements
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #13 from Frédéric Demians <frederic(a)tamil.fr> --- (In reply to Jonathan Druart from comment #12) > Olli, Could you provide a rebased patch? > It seems that bug 15406 would need the second patch. And this part of the 1st patch: diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql index e9d836c..c2eec84 100644 --- a/installer/data/mysql/kohastructure.sql +++ b/installer/data/mysql/kohastructure.sql @@ -209,6 +209,7 @@ CREATE TABLE `biblioitems` ( -- information related to bibliographic records in KEY `isbn` (`isbn`(255)), KEY `issn` (`issn`(255)), KEY `publishercode` (`publishercode`), + KEY `timestamp_bibno` (`timestamp`, `biblionumber`), CONSTRAINT `biblioitems_ibfk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8; @@ -866,7 +867,8 @@ CREATE TABLE `deletedbiblioitems` ( -- information about bibliographic records t KEY `bibnoidx` (`biblionumber`), KEY `itemtype_idx` (`itemtype`), KEY `isbn` (`isbn`(255)), - KEY `publishercode` (`publishercode`) + KEY `publishercode` (`publishercode`), + KEY `timestamp_bibno` (`timestamp`, `biblionumber`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15358] merge.pl does not populate values to merge
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Julian Maurice from comment #43) > (In reply to Jonathan Druart from comment #40) > > Julian, I have found a bug when testing: > > I a non-repeatable subfield is added when a repeatable field is added, there > > is no warning. > > If I click on the subfield, I get "The subfield is non-repeatable and > > already exists in the destination record. Therefore, you cannot add it." and > > it is not added to the destination record. > > I think it's normal behaviour if I understand correctly. The subfield is not > repeatable in its own field, but here you add a new field in the destination > record, so it's valid. Indeed! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15108] OAI-PMH provider improvements
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Olli, Could you provide a rebased patch? It seems that bug 15406 would need the second patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '16

02 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 47303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47303 BZ 7728 adding unit test Review of attachment 47303: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=772…) ----------------------------------------------------------------- 1/ Should not we update the histenddate if it has been set? 2/ Could we imagine fixing existing DB entries? ::: t/db_dependent/Serials/ReNewSubscription.t @@ +40,5 @@ > + > +#my $mContext = new Test::MockModule('C4::Context'); > +#$mContext->mock( 'userenv', sub { > +# return { branch => $library->{branchcode} }; > +#}); Useless commented lines, please remove. @@ +94,5 @@ > +# Actual testing starts here! > + > +# Renew the subscription and check that enddate has not been set > +ReNewSubscription($subscription->{subscriptionid},'',"2016-01-01",'','',12,''); > +my @history = Koha::Subscription::Histories->search( {subscriptionid => $subscription->{subscriptionid} } ); use Koha::Subscription::Histories->find( $subscription->{subscriptionid} ) when you already have the primary key. -- You are receiving this mail because: You are watching all bug changes.

1 0