February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- This is not working for me. When I try to add a message on the circulation page it does not get saved. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15586] References to Koha::Branches remain in unit tests
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Julian Maurice <julian.maurice(a)biblibre.com> --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11569] Typo in userpermissions.sql
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11569 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15358] merge.pl does not populate values to merge
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #36 from Nick Clemens <nick(a)bywatersolutions.com> --- I merged records with control fields and was able to mix and match from separate records with no issue. I tried creating subfields in control fields in MarcEdit but had no success -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15601] TestBuilder tests are failing
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |julian.maurice(a)biblibre.com --- Comment #6 from Julian Maurice <julian.maurice(a)biblibre.com> --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47522|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 47523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47523&action=ed… [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchInfo C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl The occurrence can easily be replaced by a call to Koha::Libraries->find Test plan: 1/ Create a suggestion for library A 2/ Enable OPACViewOthersSuggestions 3/ Use a patron from library B to see the suggestions 4/ The "Suggested for" value should be correctly filled with the library A name. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47001|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 47522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47522&action=ed… [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove ModBranch This subroutine was only used in tests to add/update a library. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47000|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 47521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47521&action=ed… [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchDetail C4::Branch::GetBranchDetail retrieved library infos, it could be easily replaced with Koha::Libraries->find When this change needs other big changes, the unblessed method is called, to manipulate a hashref (as before) instead of a Koha::Library object (for instance when $library is sent to GetPreparedLetter). Test plan: 1/ Print a basket group, the library names should be correctly displayed. 2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED notice will be generated (focus on the library name) 3/ Edit a patron and change his/her library 4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and have a look at the generated notices 5/ Same of overdues notices 6/ Set IndependentBranches and use a non superlibrarian user to place a hold. The "pickup at" should be correctly filled. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0