February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14893] Separate temporary storage per instance in Upload.pm
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5515] Leading 'and' in search never returns a result
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15358] merge.pl does not populate values to merge
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Nick Clemens from comment #34) > Retesting I couldn't recreate that error, seems to have been in my records, > but I reloaded since then and all tests I tried worked fine. You error was about control field (<10), did you try that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47516&action=ed… Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47096|0 |1 is obsolete| | Attachment #47097|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47515&action=ed… Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15355] Translatability: Fix issues on check in page
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15355 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15716 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 --- Comment #8 from Frédéric Demians <frederic(a)tamil.fr> --- (In reply to Sophie MEYNIEUX from comment #7) > It seems to have the same pb on Hold(s) tab Which version? Is it solved on 3.20.8? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14523] Google jackets being blocked when OPAC using HTTPS
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 --- Comment #11 from Frédéric Demians <frederic(a)tamil.fr> --- (In reply to Barry Cannon from comment #9) > My very first patch on this thread, 40988, did exactly that! Can that be > re-used? Yes! Done. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14523] Google jackets being blocked when OPAC using HTTPS
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47501|0 |1 is obsolete| | --- Comment #10 from Frédéric Demians <frederic(a)tamil.fr> --- Created attachment 47511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47511&action=ed… Bug 14523 - Google jackets being blocked when OPAC using HTTPS This patch changes the Google jackets URL to use HTTPS instead of HTTP. Signed-off-by: Frédéric Demians <f.demians(a)tamil.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0