February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14753] Show accession date on checkin
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48404|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 48405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48405&action=ed… Bug 14753 - Use columns configuration for checkins table This patch adds the ability to configrue the visible columns on the check in screen. To test with both patches: 1 - Check in an item 2 - Note there is no 'Date acquired' column 3 - Apply patches 4 - Note there is still no 'Date acquired' column 5 - Note that there is now a "Show / hide columns" button 6 - Verify that you can check the box and view the 'Date acquired' column 7 - Verify that showing/hiding columns works (it will not carry over between items due to page reload) 8 - Verify that changes from the 'Configure columns' section of Administration hold between checkins Sponsored by: North Central Regional Library (ncrl.org) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15845] New: Renewal date in circulation.pl is not always correct and not even used
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 Bug ID: 15845 Summary: Renewal date in circulation.pl is not always correct and not even used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 15841] New: Final truth value in C4:Circulation has become displaced
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Bug ID: 15841 Summary: Final truth value in C4:Circulation has become displaced Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Last thing in a module should be a true value, looks as though a subroutine has been added after the one in circulation. Lets put it back where it should be -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 15622] Spelling mistake in printfreercpt.pl
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #9 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15416] Warns on Guided Reports page
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #8 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15847] New: Correct JSHint errors in basket.js
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Bug ID: 15847 Summary: Correct JSHint errors in basket.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: hector.hecaxmmx(a)gmail.com, testopia(a)bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in basket.js basket.js: line 53, col 36, Use '===' to compare with '0'. basket.js: line 85, col 42, Missing semicolon. basket.js: line 210, col 5, Implied eval. Consider passing a function instead of a string. basket.js: line 219, col 44, Missing semicolon. basket.js: line 243, col 46, Missing semicolon. basket.js: line 251, col 29, Use '===' to compare with '0'. basket.js: line 270, col 13, 'valCookie' is already defined. basket.js: line 305, col 13, Use '===' to compare with 'undefined'. basket.js: line 409, col 25, The array literal notation [] is preferable. basket.js: line 416, col 25, Use '===' to compare with '0'. basket.js: line 432, col 33, Missing semicolon. basket.js: line 1, col 11, Missing semicolon. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 14753] Show accession date on checkin
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 --- Comment #10 from Marc Véron <veron(a)veron.ch> --- Hi Nick, I tested, the 'Show/hide columns' button does not appear and I have a JavaScript error (browser cache cleared): Zeitstempel: 26.02.2016 16:35:06 Fehler: SyntaxError: expected expression, got keyword 'var' Quelldatei: http://10.0.0.62:8080/cgi-bin/koha/circ/returns.pl Zeile: 411, Spalte: 4 Quelltext: var returns_table = KohaTable("#checkedintable", { -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15844] New: Correct JSHint errors in staff-global.js
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 Bug ID: 15844 Summary: Correct JSHint errors in staff-global.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in staff-global.js staff-global.js: line 7, col 73, Missing semicolon. staff-global.js: line 7, col 75, Missing semicolon. staff-global.js: line 16, col 2, Unnecessary semicolon. staff-global.js: line 103, col 13, 'newin' is already defined. staff-global.js: line 125, col 39, Use '===' to compare with '0'. staff-global.js: line 125, col 73, Use '===' to compare with '0'. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 15843] New: Move MARC subfields structure JavaScript into separate file
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 Bug ID: 15843 Summary: Move MARC subfields structure JavaScript into separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Coding guideline JS1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaS…) says "Whenever possible JavaScript should be placed in a separate file." The JavaScript embedded in admin/marc_subfields_structure.tt is not dependent on template processing, so it can be safely moved to a separate file. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 15777] New: Refactor loop in which Record::Processor does not initialize parameters
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Bug ID: 15777 Summary: Refactor loop in which Record::Processor does not initialize parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org foreach my $filter (@{ $req_filters }) { next unless $filter; my $filter_module = $filter =~ m/:/ ? $filter : "Koha::Filter::${schema}::${filter}"; if (can_load( modules => { $filter_module => undef } )) { my $object = $filter_module->new(); $filter_module->initialize($param); push @filters, $object; } } "$filter_module->initialize($param);" should be "$object->initialize($param); Additionally, object isn't really descriptive, and it isn't clear that $filter is the string name of the filter. So, this loop will have some variable renaming done on it. And the first commit will include a test that fails to initialize. And the second commit will include this revision which should then pass. -- You are receiving this mail because: You are watching all bug changes.

1 20