February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15671] Show branch name instead of branch code in checkout history
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14457] Integrate LIBRIS spellchecking
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think if a pref - better have a proper one so we know what's going on there :) The Did-you-mean-feature already has a very modulized structure, so I think adding to that should be ok for now until we can give the whole topic more thought. It won't hurt anyone and it doesn't touch core routines/templates apart from the small change in the include. Maybe we need to think about a good way to store configuration options for plugins? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11201] List pending in-house checkouts
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 [Bug 15841] Final truth value in C4:Circulation has become displaced -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14457] Integrate LIBRIS spellchecking
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #20) > Looking at the code this seems a very specific feature, like Amazon-Covers, > Syndectics, etc. > > Koha::SuggestionEngine::Plugin::LibrisSpellcheck; The name does not tell that this is only interesting for Swedish libs. > So if the URL is always the same and there is no other service this plugin > works with - a configuration option doesn't seem necessary. The URL has changed already :) Note that e.g. Syndetics has 12 prefs or so in Koha. (In reply to Eivin Giske Skaaren from comment #21) > It seems like they have changed the url to http://api.libris.kb.se/bibspell/ > so perhaps some way of changing it without committing code would be good. > Please advise on the preferred solution. I do not really oppose a pref here. But you could use a local pref, or an "undocumented" koha-conf variable. Not ideal, since you would reference it from standard code.. The whole problem here is: How do we adjust Koha to include various language specific features (like this one)? Should they be part of the core code or not? Note that we recently had such a discussion about NorwegianPatronDB. There is no clear answer yet. For the time being, I would not oppose two prefs and toggling this feature via admin/didyoumean. Final word to the RM. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15163] Patron attributes with branch limiits are not saved when invisible
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48269&action=ed… Bug 15163: Do not erase patron attributes if limited to another library The patron attributes displayed on editing a patron are not displayed if limited to another library. C4::Members::Attributes::SetBorrowerAttributes will now only delete attributes the librarian is editing. SetBorrowerAttributes takes a new $no_branch_limit parameter. If set, the branch limitations have not effect and all attributes are deleted (same behavior as before this patch). Test plan: 1/ Create 2 patron attributes, without branch limitations. 2/ Edit a patron and set a value for these attributes 3/ Limit a patron attributes to a library (one you are not logged in with). 4/ Edit again the patron. => You should not see the limited attributes 5/ Edit the patron attributes and remove the branch limitation => Without this patch, it has been removed from the database and is not displayed anymore. => With this patch, you should see it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15163] Patron attributes with branch limiits are not saved when invisible
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7) > Not sure it's needed, as the test is very simple. > Where would you move this subroutine? If we would ever have to change this very simple test, it would also be very easy to overlook a simple test. I would keep it close to GetMarcStructure. > Yes but it works for the moment :) The structure has not changed for years. True > Imo, that would make the test less strong and too specific. OK So, I prefer to move the ref-test to a subroutine in Biblio.pm IsMarcStructureInternal ? or something ? That would be the only place to document this test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15298] z39.50 admin setup, options column suggested changes
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15875 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14893] Separate temporary storage per instance in Upload.pm
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Frédéric Demians from comment #15) > This patch depends on a 3.22 enhancement which isn't available on 3.22 > branch: see bug 14321. I can't backport and fix in the same time. Seems too > risky. From my perspective, if it's a major issue on 3.20, a separate bug > should be open, and a patch attached, specifically for 3.20. The development this depends on, was pushed to 3.22. So this patch is not directly related to problems in 3.20. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11360] Disable barcode field and submit button when a hold is found
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '16

22 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron(a)veron.ch --- Comment #25 from Marc Véron <veron(a)veron.ch> --- Sorry, there is a merge conflict in returns.tt -- You are receiving this mail because: You are watching all bug changes.

1 0