February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 [Bug 15548] New patron related code should have been put to Patron instead of Borrower -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48117&action=ed… Bug 15635: Change method type to _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48116&action=ed… Bug 15635: Koha::Patron::Images - Remove GetPatronImage To retrieve a patron image, we can call Koha::Patron::Images->find or Koha::Patrons->find->image Both will return a Koha::Patron::Image object. Test plan: 1/ From the patron/member module, open all tabs on the left (Checkouts, detail, fines, etc.) The image should be correctly displayed. 2/ At the OPAC, on the patron details page (opac-memberentry.pl) the image should be displayed as well. 3/ Same on the sco module. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48115&action=ed… Bug 15635: Koha::Patron::Images - Remove RmPatronImage The C4::Members::RmPatronImage just removed a row in patronimage. This can be accomplished using the delete method of Koha::Patron::Image. Test plan: >From the patron defail page, try to delete the image of a patron. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48114&action=ed… Bug 15635: Koha::Patron::Images - Remove PutPatronImage The C4::Members::PutPatronImage inserted/updated the image of a patron. This can be done easily with ->find->set->store or ->new->store Test plan: 1/ Modify the image of a patron from the patron detail page 2/ Add an image to a new patron 3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of a patron 4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of several patrons, using a zip file. Stress the script trying to get as many errors as possible (wrong cardnumber, wrong mimetype, file does not exist, etc.) With this patch, if the cardnumber does not exist, you will get a specific error "Image not imported because this patron does not exist in the database" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47122|0 |1 is obsolete| | Attachment #47124|0 |1 is obsolete| | Attachment #47125|0 |1 is obsolete| | Attachment #47126|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48113&action=ed… Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15548] New patron related code should have been put to Patron instead of Borrower
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Just another rebase. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15548] New patron related code should have been put to Patron instead of Borrower
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48112&action=ed… Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15548] New patron related code should have been put to Patron instead of Borrower
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47103|0 |1 is obsolete| | Attachment #47104|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48111&action=ed… Bug 15548: Move new patron related code to Patron* The 'borrower' should not be used anymore, especially for new code. This patch move files and rename variables newly pushed (i.e. in the Koha namespace). Test plan: 1/ git grep Koha::Borrower should not return code in use. 2/ Prove the different modified test files 3/ Do some clicks in the member^Wpatron module to be sure there is not an obvious error. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as described. Tested with Circulation, Members/Patrons, Discharge, Restrictions modules and the must common functionalities Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0