February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15219] Load checkouts table incrementally
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Load checkouts table incrementally
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #6 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 48107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48107&action=ed… Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 --- Comment #3 from Eivin Giske Skaaren <eivin(a)sysmystic.com> --- Hi David, I did some initial work on this but it was abandoned for now because of the security aspect. Exposing root shell via CGI might not be a good idea. If you have a good solution that also perhaps solves some of the things that we wanted to solve with this I would be happy to test/sign-off your patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Load checkouts table incrementally
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #5 from Julian Maurice <julian.maurice(a)biblibre.com> --- Loading checkouts table incrementally takes more time to load all lines than to load them all at once, so I'll go with a classic paginated table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Note: This is just for display purpose, this new field is never used for sending notices to patrons. QA comment: - The second patch modifies "Other phone" with "Mobile phone". "Other phone" is used in master atm - The deletedborrowers table structure should be modified too - It would be good to let the user modify this value from the OPAC, don't you think? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47968|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 48099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48099&action=ed… Bug 5404: C4::Koha - remove subfield_is_koha_internal_p The commit b5ecefd485a75d54a5fa26fff5a0cc890541e2c3 Date: Mon Feb 3 18:46:00 2003 +0000 had a funny description: Added function to check if a MARC subfield name is "koha-internal" (instead of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm "Temporarily", since 2003, everything is relative, isn't it? :) The thing is that GetMarcStructure returns hash like field_200 => { subfield_a => { %attributes_of_subfield_a }, %attributes_of_field_200 } The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'. We don't want to loop on these values when looping on subfields. Since there are just { k => v } with v is a scalar (string), it's easier to test if we are processing a subfield testing the reference. At some places, we don't need to test that, we are looping on values from MARC::Field->subfields which are always valid subfields. Test plan: 1/ Edit items using the batch item mod tool 2/ display and edit items via the cataloguing module. You should not see any changes between before and after the patch applied. Tech notes: We need to check what we are processing when we loop on 'subfields' from GetMarcStructure, not from MARC::Field->subfields. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14637] Add patron category fails with MySQL 5.6.26
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15819 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13805] Installer does not work under Plack
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #16) > Do we need to take another look at this? Yes. Tomas, could you confirm that we don't need to disable this cache anymore? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15269] Layout tweaks for the opac-detail page
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '16

16 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0