March 2016 - Koha-bugs - lists.koha-community.org

[Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 49036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49036 Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees Review of attachment 49036: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=145…) ----------------------------------------------------------------- - circ/circulation_batch_checkouts.tt will need to be modified too - The tests in Patron.t are not necessary. It's covered by t/db_dependent/Koha/Patrons.t ::: C4/Circulation.pm @@ +852,5 @@ > my $allfinesneedoverride = C4::Context->preference("AllFinesNeedOverride"); > + > + # Check the debt of this patrons guarantees > + my $no_issues_charge_guarantees = C4::Context->preference("NoIssuesChargeGuarantees"); > + $no_issues_charge_guarantees = undef unless looks_like_number( $no_issues_charge_guarantees ); Is there a difference with 'defined $a && $a > 0'? @@ +867,5 @@ > + $issuingimpossible{DEBT_GUARANTEES} = sprintf( "%.2f", $guarantees_non_issues_charges ); > + } elsif ( $guarantees_non_issues_charges > $no_issues_charge_guarantees && !$inprocess && $allowfineoverride) { > + $needsconfirmation{DEBT_GUARANTEES} = sprintf( "%.2f", $guarantees_non_issues_charges ); > + } elsif ( $allfinesneedoverride && $guarantees_non_issues_charges > 0 && $guarantees_non_issues_charges <= $no_issues_charge_guarantees && !$inprocess ) { > + $needsconfirmation{DEBT_GUARANTEES} = sprintf( "%.2f", $guarantees_non_issues_charges ); It would be better to use the Price TT plugin to display these values. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #34 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49131&action=ed… Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Check out and return an item for a patron 4) Delete that item 5) Verify the record still shows in the patron's reading history 6) Delete the record entirely 7) Verify the record still shows in the patron's reading history, but that the title is now just text instead of a hyperlink. Signed-off-by: Heather Braum <hbraum(a)nekls.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #33 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49130&action=ed… Bug 8483 - Add record and item related classes Signed-off-by: Heather Braum <hbraum(a)nekls.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42939|0 |1 is obsolete| | Attachment #42940|0 |1 is obsolete| | Attachment #42941|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49129&action=ed… Bug 8483 - Add checkout classes Signed-off-by: Heather Braum <hbraum(a)nekls.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Katrin, could you confirm it is what you had in mind? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 49122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49122&action=ed… Bug 13238: Specific string if no results Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49110|0 |1 is obsolete| | --- Comment #30 from Marc Véron <veron(a)veron.ch> --- Created attachment 49121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49121&action=ed… Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16067 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16067 [Bug 16067] Koha::Cache, fastmmap caching system is broken -- You are receiving this mail because: You are watching all bug changes.

1 0