March 2016 - Koha-bugs - lists.koha-community.org

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49027|0 |1 is obsolete| | --- Comment #158 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 49105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49105&action=ed… Bug 11998: Revert "Bug 13805: (Plack) Disable syspref cache" This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58. Bug 13805 fixes an installer bug by disabling the syspref cache. It was not a good idea, it introduced performance issues (see bug 13805 comment 14). Test plan: Test plan: 0/ Create a new database and fill the database entry in the koha conf with its name 1/ Go on the mainpage, you should be redirected to the installer 2/ Try to log in You should not get the login form again. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Test plan not followed by me for this patch, due to lack of working plack setup, but I don't expect it to cause any problems, and performace gain for plack will be tremendous -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49026|0 |1 is obsolete| | --- Comment #157 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 49104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49104&action=ed… Bug 11998: Do not clear syspref cache in psgi file This in only in koha.psgi, it has been introduced by bug 13815 but should not have been added by this patch. Removing it should not introduce any changes. Not that it won't impact debian packages. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49025|0 |1 is obsolete| | --- Comment #156 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 49103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49103&action=ed… Bug 11998: Make HoldsQueue.t tests pass [TO REVERT] This patch should not be the way to make these tests pass. The prefs should not be updated using set_preference, it will modify the values in the cache. I have no idea how to make them pass using the correct way, please help :) Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49024|0 |1 is obsolete| | --- Comment #155 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 49102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49102&action=ed… Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm Otherwise some tests won't pass Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49023|0 |1 is obsolete| | --- Comment #154 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 49101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49101&action=ed… Bug 11998: Use t::lib::Mocks::mock_preference in tests Unless in t/db_dependent/Context.t where we want to test the cache behaviors. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49022|0 |1 is obsolete| | --- Comment #153 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 49100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49100&action=ed… Bug 11998: Use Koha::Cache to cache sysprefs At the moment, the sysprefs are only cache in the thread memory executing the processus When using Plack, that means we need to clear the syspref cache on each page. To avoid that, we can use Koha::Cache to cache the sysprefs correctly. A big part of the authorship of this patch goes to Robin Sheat. Test plan: 1/ Add/Update/Delete local use prefs 2/ Update pref values and confirm that the changes are correctly taken into account Signed-off-by: Chris <chrisc(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Tested with plack with syspref cache enabled, there is some time between setting the syspref and applying it, but it takes just one reload of page, it shouldn't be problem, should it? Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> Tested with CGI and CGI + memcache; some small issues still remain, but it would be better to deal with them in separate bug reports if necessary -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16065 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16061 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16060 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16059 -- You are receiving this mail because: You are watching all bug changes.

1 0