March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15656] Move the guarantor/guarantees code to Koha::Patron
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '16

12 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 --- Comment #7 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49056&action=ed… Bug 15656 [QA Followup] - Return without searching if patron has no guarantor Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15656] Move the guarantor/guarantees code to Koha::Patron
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '16

12 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 --- Comment #6 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49055&action=ed… Bug 15656: Move guarantor/guarantees code - GetMemberRelatives Note: QA question: Does the Koha::Patron->siblings method should return undef if there is no guarantor? It would avoid the weird != undef, = $borrowernumber conditions. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15656] Move the guarantor/guarantees code to Koha::Patron
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '16

12 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48108|0 |1 is obsolete| | Attachment #48109|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49054&action=ed… Bug 15656: Move guarantor/guarantees code - GetGuarantees 2 subroutines of C4::Members deal with guarantor/guarantees: GetGuarantees and GetMemberRelatives. Since we already have a Koha::Patron->guarantor method, it makes sense to move these 2 subroutines to this module. This first patch deals with GetGuarantees. Test plan for the entire patch set: 1/ Create 5 patrons A (adult), B (child), C (child), D (child), E (child), F (adult) 2/ Add relation between them: A is father of B, C and D. E does not have a guarantor F does not have guarantees 3/ Check some items out for all of these patrons 4/ On the "Check out" and "Details" tabs, you should not see any differences with these patch applied : The "Relatives' checkouts" tabs should list all of the guarantor/guarantee/siblings checkouts Note: $template->param('C' => 1); I have not found any reference of this 'C' in the template. It seems it's an old c/p from members/memberentrygen.tt Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15656] Move the guarantor/guarantees code to Koha::Patron
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '16

12 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15653] Updating a guarantor has never updated its guarantees
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48662|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49051&action=ed… Bug 15653: Remove unused C4::Members::UpdateGuarantees subroutine Looking at the code, there is some broken with the guarantees code. It seems that the expected behavior would be to update address, fax, B_city, mobile, city and phone info of the guarantees when a guarantor is modified. But the code in C4::Members::ModMember is broken: 668 my $borrowercategory= GetBorrowercategory( $data{'category_type'} ); 669 if ( exists $borrowercategory->{'category_type'} && $borrowercategory->{'category_type'} eq ('A' || 'S') ) { 670 # is adult check guarantees; 671 UpdateGuarantees(%data); 672 } First, GetBorrowerCategory expects a categorycode, not a category_type. Then UpdateGuarantees retrieves the param like: 989 sub UpdateGuarantees { 990 my %data = shift; Which means that %data will always be something like ( a_key => undef ) And nothing more. The updateguarantees subroutine (It has been renamed) has been introduced by commit 56825e415fc232e38f0a874dc9a81fa2169ef06b Date: Mon Aug 30 13:48:58 2004 +0000 modularizing (with Members.pm) members management (beginning of...) And the `%data = shift` already existed... This code has never worked and could be removed. See http://lists.koha-community.org/pipermail/koha-devel/2016-January/042241.ht… Test plan: Confirm the previous assertions. Note that I have found this bug working on bug 15631, see patch "Bug 15631: Koha::Cities - remove getidcity and GetCities" Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15653] Updating a guarantor has never updated its guarantees
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16055 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jonathan Field <jonathan.field(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #154 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49042&action=ed… Bug 7736 [QA Followup] - Fix spelling and pod errors Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #153 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 49041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49041&action=ed… Bug 7736 [QA Followup] - Fix SQL, Add description field for Library EANs Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0