March 2016 - Koha-bugs - lists.koha-community.org

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48933|0 |1 is obsolete| | --- Comment #148 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49027&action=ed… Bug 11998: Revert "Bug 13805: (Plack) Disable syspref cache" This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58. Bug 13805 fixes an installer bug by disabling the syspref cache. It was not a good idea, it introduced performance issues (see bug 13805 comment 14). Test plan: Test plan: 0/ Create a new database and fill the database entry in the koha conf with its name 1/ Go on the mainpage, you should be redirected to the installer 2/ Try to log in You should not get the login form again. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48932|0 |1 is obsolete| | --- Comment #147 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49026&action=ed… Bug 11998: Do not clear syspref cache in psgi file This in only in koha.psgi, it has been introduced by bug 13815 but should not have been added by this patch. Removing it should not introduce any changes. Not that it won't impact debian packages. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48931|0 |1 is obsolete| | --- Comment #146 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49025&action=ed… Bug 11998: Make HoldsQueue.t tests pass [TO REVERT] This patch should not be the way to make these tests pass. The prefs should not be updated using set_preference, it will modify the values in the cache. I have no idea how to make them pass using the correct way, please help :) Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48930|0 |1 is obsolete| | --- Comment #145 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49024&action=ed… Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm Otherwise some tests won't pass Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13371] Add filters to the supplier list view
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48929|0 |1 is obsolete| | --- Comment #144 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49023&action=ed… Bug 11998: Use t::lib::Mocks::mock_preference in tests Unless in t/db_dependent/Context.t where we want to test the cache behaviors. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13371] Add filters to the supplier list view
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud(a)biblibre.com Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48928|0 |1 is obsolete| | --- Comment #143 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49022&action=ed… Bug 11998: Use Koha::Cache to cache sysprefs At the moment, the sysprefs are only cache in the thread memory executing the processus When using Plack, that means we need to clear the syspref cache on each page. To avoid that, we can use Koha::Cache to cache the sysprefs correctly. A big part of the authorship of this patch goes to Robin Sheat. Test plan: 1/ Add/Update/Delete local use prefs 2/ Update pref values and confirm that the changes are correctly taken into account Signed-off-by: Chris <chrisc(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Tested with plack with syspref cache enabled, there is some time between setting the syspref and applying it, but it takes just one reload of page, it shouldn't be problem, should it? Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13371] Add filters to the supplier list view
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36759|0 |1 is obsolete| | --- Comment #51 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 49021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49021&action=ed… Bug 13371: Add a simple view This patch adds the ability to switch to a simple view if the complete view to too complex. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13371] Add filters to the supplier list view
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '16

11 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34439|0 |1 is obsolete| | --- Comment #50 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 49020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49020&action=ed… Bug 13371: Move firstname and surname closer On this way, they can be searched together ("my_firstname my_surname"). Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0