March 2016 - Koha-bugs - lists.koha-community.org

[Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15997 --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Bug 15997 has been filed to replace the need for this bug patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #12 from Heather Braum <hbraum(a)nekls.org> --- Jonathan, we're needing to use Koha's Self Check at multiple branches, so have to use multiple logins; we can't save those to the AutoSelfCheckID sys pef as a result. Hence the development need. I'll can't answer the complexity question :) I'll let Nick do that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #116 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Sorry, forget this last comment (I was using master... :D) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13298] Holds ratios report ignores ordered items
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13298 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall(a)gmail.com --- Comment #8 from Kyle M Hall <kyle(a)bywatersolutions.com> --- *** Bug 7887 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marc Véron from comment #12) > Still valid? Half valid. The ability to count on order items was added with another patch, but only if items are created at the time of ordering. I will close this bug out and open a new one to add just that additional functionality. *** This bug has been marked as a duplicate of bug 13298 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #115 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jacek Ablewicz from comment #114) > I'm unable to test this patch set with fastmmap caching system - it seems to > break it somehow.. With patch, and fastmmap cache enabled, anything (?) that > uses Koha::Cache results with: > > Use of uninitialized value $db_name in concatenation (.) or string at > /home/koha/devkohaclone/Koha/Database.pm line 73. > Use of uninitialized value $db_host in concatenation (.) or string at > /home/koha/devkohaclone/Koha/Database.pm line 73. > DBI connect('database=;host=;port=','',...) failed: Access denied for user > 'koha'@'localhost' (using password: NO) at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1249 > DBIx::Class::Storage::DBI::dbh(): DBI Connection failed: Access denied for > user 'koha'@'localhost' (using password: NO) at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1253. at > /home/koha/devkohaclone/Koha/Database.pm line 90 > > To reproduce (on command line) > > 0) ensure that you have fastmmap perl module installed > (libcache-fastmmap-perl in debian) > 1) apply patch (without patch: no error in current master) > 2) export CACHING_SYSTEM=fastmmap > 3) export GATEWAY_INTERFACE=1 > 4) try to run this simple script: > > #!/usr/bin/perl > > use Modern::Perl; > use C4::Biblio; > GetMarcStructure(); I don't get the error. I don't know if I did something wrong, I don't use fastmmap (I thought we agree it does not have good results). % git diff diff --git a/Koha/Cache.pm b/Koha/Cache.pm index 9856e80..e0f406f 100644 --- a/Koha/Cache.pm +++ b/Koha/Cache.pm @@ -123,6 +123,7 @@ sub new { $ENV{DEBUG} && carp "Selected caching system: " . ($self->{'cache'} // 'none'); + use Data::Dumper;warn Dumper $self; return bless $self, $class; % more t.pl #!/usr/bin/perl use Modern::Perl; use C4::Biblio; GetMarcStructure(); % perl t.pl $VAR1 = { 'memory_cache' => bless( { 'size_limit' => undef, 'namespace' => 'koha', 'load_callback' => undef, 'default_expires' => '0 sec', 'removal_strategy' => bless( {}, 'Cache::RemovalStrategy::LRU' ), 'validate_callback' => undef }, 'Cache::Memory' ), 'timeout' => 0, 'namespace' => 'koha', 'Cache::Memory_get' => sub { "DUMMY" }, 'cache' => bless( { 'Cache' => \205625248, 'allow_recursive' => undef, 'share_file' => '/tmp/sharefile-koha-koha-localhost-koha', 'write_back' => '', 'context' => undef, 'delete_cb' => undef, 'empty_on_exit' => 0, 'num_pages' => 89, 'compress' => 0, 'enable_stats' => 0, 'raw_values' => 0, 'write_cb' => undef, 'read_cb' => undef, 'cache_not_found' => undef, 'pid' => 17602, 'expire_time' => 0, 'page_size' => 65536, 'unlink_on_exit' => 0, 'cache_size' => 5832704 }, 'Cache::FastMmap' ), 'fastmmap_cache' => $VAR1->{'cache'}, 'Cache::Memory_set' => sub { "DUMMY" }, 'default_type' => 'fastmmap' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #52 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48747&action=ed… Bug 15084 [QA Followup] - Fix new uses of GetCurrency Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15871] New: Improve perl critic of t/RecordProcessor.t
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 Bug ID: 15871 Summary: Improve perl critic of t/RecordProcessor.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org perlcritic -5 t/RecordProcessor fails with: Don't modify $_ in list functions at line 43, column 25. See page 114 of PBP. (Severity: 5) This is because of a hacky good single line of code. While correcting this for improved readability, attempt to get this to a higher level of perl critic. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 15693] New: Unnecessary punctuation mark when check-in an item in a library other than the home branch
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 Bug ID: 15693 Summary: Unnecessary punctuation mark when check-in an item in a library other than the home branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: hector.hecaxmmx(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If you are checking an item in at a library other than the home branch, a message will appear asking you to transfer the book to the home library. Thit message appear with "Print slip )" and the unnecessary punctuation mark -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 14097] Add unit tests to C4::UsageStats
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #60 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.

1 0