March 2016 - Koha-bugs - lists.koha-community.org

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #45 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Patches rebased (it was a nightmare...) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48741&action=ed… Bug 12904: Update new occurrences of .js|.css This has been generated using the script attached to the bug report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48740&action=ed… Bug 12904 [Followup] - Add to Intranet for Dev Install I managed to miss the intranet vhost directive first time around.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48739&action=ed… Bug 12904 [Followup] - Catch remaining JS files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48738&action=ed… Bug 12904 [Followup] - Increase CSS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for css files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48737&action=ed… Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48736&action=ed… Bug 12904 [Followup] - Increase JS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for javascript files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33323|0 |1 is obsolete| | Attachment #33324|0 |1 is obsolete| | Attachment #33325|0 |1 is obsolete| | Attachment #33326|0 |1 is obsolete| | Attachment #33327|0 |1 is obsolete| | Attachment #33328|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48735&action=ed… Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15867] New: Move MARC modification templates JavaScript into separate file
by bugzilla-daemon＠bugs.koha-community.org 07 Mar '16

07 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 Bug ID: 15867 Summary: Move MARC modification templates JavaScript into separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Coding guideline JS1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaS…) says "Whenever possible JavaScript should be placed in a separate file." The JavaScript embedded in tools/marc_modification_templates.tt is not so dependent on template processing that it can't be safely moved to a separate file. -- You are receiving this mail because: You are watching all bug changes.

1 10