March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47218|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48599&action=ed… Bug 15084: Add tests for Koha::Acquisition::Currenc[y|ies] Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47217|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48598&action=ed… Bug 15084: Remove C4::Budgets::ConvertCurrency This subroutine is unused and can be removed. There is no trace left of currency in C4::Budgets. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47216|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48597&action=ed… Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search Most part of the code here is unnecessary complex. We should selected the currency if it is selected, that's all :) Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47215|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48596&action=ed… Bug 15084: use Koha::Acquisition::Currenc[y|ies] in admin/currency Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47214|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48595&action=ed… Bug 15084: Make sure the previous active currency is marked as inactive On inserting an active currency, others should be marked as inactive. We can only have 1 active currency at the same time. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47213|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48594&action=ed… Bug 15084: Add Koha::Acquisition::Currenc[y|ies] classes The first step of this patch set is to move the business logic code from admin/currencies.pl to Koha::Acquisition::Currenc[y|ies]. Then a foreign key will be created on aqorders.currency as we want to assure data integrity. Note that a aqbooksellers.currency also exists but is never used. It could be removed in another bug report. This update has to care about possible breaking relation. For instance an old order has been made using a currency which is now deleted. To be sure the update process won't break a new column currency.archived is created and leave open the door for a further improvement (marked a currency as archived from the interface: this won't be provided by this enhancement). These archived currencies won't appear on the interface for newly created items (order/suggestion). Once this is done it becomes easy to remove the subroutine from C4::Budgets: GetCurrencies and GetCurrency. ConvertCurrency will also be removed but is not used anymore. Note that none of these subroutines were covered by tests. Now they are. Test plan: 0/ Don't apply this patch 1/ Create a temporary currency and an order using it 2/ Remove the currency from your CLI 3/ Apply the patch and execute the DB entry 4/ Note that the currency is inserted and marked as archived. 5/ Edit the previous order and confirm that the correct currency is still selected. It won't never be displayed anywhere else. 6/ Test the admin script: on admin/currency.pl add/remove/edit currencies. You could not have 2 active currencies at the same time. 7/ Then on the different scripts of the acquisition module, focus on the currencies values and create a new order, receive it. Create/edit a suggestion Other changes must be checked by the QAer. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14889] Move the framework related code to Koha::BiblioFramework[s]
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Brendan Gallagher from comment #24) > Didn't apply cleanly - I know because of the moving target that master is. > Please rebase. Once it's done - leave me an @later in #koha and I'll jump > right on it. Thank you so much for the time and bother of rebasing. > > Brendan Brendan, we just need the last patch, others are already pushed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48593&action=ed… Bug 15632 [QA Followup] - Change method type to _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #49 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48592&action=ed… Bug 15632 [QA Followup] - Undo changes needed for Bug 13618 which was reverted -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48425|0 |1 is obsolete| | Attachment #48426|0 |1 is obsolete| | Attachment #48427|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48591&action=ed… Bug 15632 [QA Followup] - Get rid of use of uninitialized value errors for unit tests * Set $user to "" if not passed * Tidy sub -- You are receiving this mail because: You are watching all bug changes.

1 0