March 2016 - Koha-bugs - lists.koha-community.org

[Bug 12803] Add ability to skip closed libraries when generating the holds queue
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |mtompset(a)hotmail.com --- Comment #82 from M. Tompsett <mtompset(a)hotmail.com> --- I'm running through patch does not apply queue. Only HoldsQueue.t file changed in terms of use statements. Test file proves fine. Everything else identical. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12803] Add ability to skip closed libraries when generating the holds queue
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47247|0 |1 is obsolete| | --- Comment #81 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48575&action=ed… Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! Bug 12803 [QA Followup] - Fix koha-qa.pl errors Bug 12803 [QA Followup] - Update unit tests due to changes in master Bug 12803 [QA Followup] - Fix to stop failing unit tests Bug 12803 [QA Followup] - Remove duplicate 'use' lines Bug 12803 [QA Followup] - Remove NO_CACHE Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12803] Add ability to skip closed libraries when generating the holds queue
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47246|0 |1 is obsolete| | --- Comment #80 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48574&action=ed… Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #55 from M. Tompsett <mtompset(a)hotmail.com> --- Sorry, Marcel, my rebase lost your sign-off markers at the end of the files. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48049|0 |1 is obsolete| | --- Comment #54 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48573&action=ed… Bug 12426: [QA Follow-up] Clear to_address to force update When resending an email from the Notices tab in Patrons, we would like to use the recent email address. Test plan: [1] Look up a patron with some notices sent. [2] Adjust the patron email address (watch AutoEmailPrimaryAddress). [3] Resend the notice. Verify if the new address was used. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47958|0 |1 is obsolete| | --- Comment #53 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48572&action=ed… Bug 12426: Allow resend for sent messages This patch allows to resend both sent and failed messages. With messages in 'sent' status, we have to be careful not to accidentally send sent messages again. With the previous patch using GET request, this was likely to happen because of browser storing the GET parameters. This patch changes request method from GET to POST. Instead of a simple link, we now have a form element. In notices.pl we redirect back to notices.pl, because with POST there is a risk of resending the message accidentally by form resubmission at refresh. To test, find/create a Patron that has sent or failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the sent or failed message 4. Observe that there is nothing for resending the sent or failed message 5. Apply the patches. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47957|0 |1 is obsolete| | --- Comment #52 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48571&action=ed… Bug 12426: Simplify the code adding a new subroutine GetMessage The C4::Letters module does not have a GetMessage subroutine, which could be quite useful. This patch adds it and simplifies the code added by the previous patch. It also adds a few tests and fixes POD typos. Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47956|0 |1 is obsolete| | --- Comment #51 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48570&action=ed… Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14133] Print notices generated in special case do not use print template
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Heather Braum <hbraum(a)nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum(a)nekls.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14133] Print notices generated in special case do not use print template
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '16

03 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- I think there is a problem here. Unless I missed something the lines below will now never be triggered, so the notice will not be pushed to output_chunks, so it will never be sent to the library in the case of a patron with no emails or sms 727 if ( ($mtt eq 'email' and not scalar @emails_to_use) or ($mtt eq 'sms' and not $data->{smsalertnumber}) ) { 728 push @output_chunks, -- You are receiving this mail because: You are watching all bug changes.

1 0