March 2016 - Koha-bugs - lists.koha-community.org

[Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49669|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49698&action=ed… Bug 14257: Follow-up - Add documentation, fix typo, fix test - t/db_dependent/ILSDI_Services.t was failing for me as I had issues in my database, fixed with another delete line - QA tools found a typo - comparision - Added documentation of the new parameter to the ilsdi.pl page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49697&action=ed… [PASSED QA] Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1 A new element <attributes> will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=1&sh… The output XML should have an element named 'attributes' containing the data you entered. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49696&action=ed… [PASSED QA] Bug 14257 - Add show_attributes to GetPatronInfo Added unit tests to for GetBorrowerAttributes and GetPatronInfo. Sponsored-By: Halland County Library Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #24 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- We can get more opinions on this - but maybe the page needs a rework? It doesn't appear as part of the self check sites at the moment, so that's why I am not sure about changing the current behavour. It shows the header and footer as all of the normal OPAC sites. If the SCOUserCSS is after the normal OpacUSerCSS you will still be able to overwrite everything that you don't like, without introducing a change in behaviour. Could that work? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15323] ./t/Prices.t fails without a valid database
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49688|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49695&action=ed… [PASSED QA] Bug 15323: Use fixtures for the active currency prove t/Prices.t fails after bug 15084 has been pushed It's caused by commit 1538e9ecf47642c4974693ff499c3e95e4d71977 Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search Koha::Number::Price->_format_params calls Koha::Acquisition::Currencies->get_active, which requests the DB. The currency data should be mocked. Test plan: sudo service mysql stop prove t/Prices.t should return green Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Patch works as expected and passes the qa-tools tests. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15323] ./t/Prices.t fails without a valid database
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #23 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #22) > By using an if-else-construct where OPACUserCSS and OpacUserJS are in the > else branch this removes all the styling done to the login page per these > preferences. As the SCO login page looks like a normal OPAC page, this > doesn't feel right. The intention here is to allow the library to make this page look different, removing the css and js that is present on the opac is intended to help that. My thought would be to add another IF/ELSE block and if this is an SCO login change "Log in to your account" to 'Staff log in to self checkout station" and maybe a link back to the opac login. Would that work for you? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #80 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 49694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49694&action=ed… Bug 10612 - Unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0