March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15008] Add custom HTML areas to circulation and reports home pages
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marc Véron from comment #7) > > I would tend to agree but think that's a separate bug > > +1 for a separate bug Any candidate to open it and write a patch? :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5334] add explicit foreign key constraints
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16170 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170 [Bug 16170] Pseudo foreign key in Items -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2685] add a foreign key from items.bibionumber to biblio.biblionumber
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2685 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16170 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15323] ./t/Prices.t fails without a valid database
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #13) > We should really have mocked unit tests for everything. Most of the problems > we have with (db_dependent) tests are side-effects from previous tests. So, > everything is much more complicated to debug than it should. Side-effects from previous tests: might depend on how you arrange your tests. You could just have the same effects when using SQLite inmemory. Some large tests may need more than one rollback. I am not saying that we should not try to make a test db independent. But imo we need to balance the work of doing so (mocking all Context stuff etc., running Test::DBIx etc.) against the advantages we hope to achieve. And although mocking may help focus on the specific test goal, not mocking might help revealing other issues.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14158] t/db_dependent/www/search_utf8.t hangs if error is returned
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14158 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan(a)bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14158] t/db_dependent/www/search_utf8.t hangs if error is returned
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14158 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA CC| |tomascohen(a)gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- QAing as it is a trivial test fix no one has cared about yet :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14158] t/db_dependent/www/search_utf8.t hangs if error is returned
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14158 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49676|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49684&action=ed… Bug 14158: www search tests - Cleanup at the end When something wrong happen, the parent process is waiting for the children to finish, but they have been zombified and the test hangs. To fix that, we should ensure that the cleanup is correctly done and that the processes are correctly killed. Test plan: export KOHA_USER=koha export KOHA_PASS=koha export KOHA_INTRANET_URL=http://do_not_exist_but_its_expected export KOHA_OPAC_URL=http://another_url prove t/db_dependent/www/search_utf8.t Without this patch, the tests will hang With the patch applied, they won't! Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14158] t/db_dependent/www/search_utf8.t hangs if error is returned
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14158 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15323] ./t/Prices.t fails without a valid database
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 --- Comment #13 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Marcel de Rooy from comment #9) > Why not move this test to db_dependent? We should really have mocked unit tests for everything. Most of the problems we have with (db_dependent) tests are side-effects from previous tests. So, everything is much more complicated to debug than it should. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3083] OPAC shows renewal link for items which are on hold or have too many renewals
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '16

30 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3083 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14434 -- You are receiving this mail because: You are watching all bug changes.

1 0