March 2016 - Koha-bugs - lists.koha-community.org

[Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49582&action=ed… Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing 'Provider' in detail page for Intranet. Test plan 1) Update zebra index if no Provider: index exist 2) Do a search by Provider: 3) Goto detail page for a record with 264 4) Look that there no display link for 264 field. 5) Apply the patch 6) Reload the page, notice about the link, click the link an confirm the new index Provider works fine 7) Test with multiple records with 260 and 264, if you prefer follow test plan for bug 14734 8) Access an RCAA2 record just with 260 field 9) Notice that 260 has been updated with Provider index too. NOTE: The intention of Provider index -according with documentation- is to collect multiples fields including 260, 264, 270, and 257 Sponsored-by: Universidad de El Salvador Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko(a)abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #7 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 49581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49581&action=ed… Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1 A new element <attributes> will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=1&sh… The output XML should have an element named 'attributes' containing the data you entered. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49579|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 49580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49580&action=ed… Bug 14257 - Add show_attributes to GetPatronInfo Added unit tests to for GetBorrowerAttributes and GetPatronInfo. Sponsored-By: Halland County Library Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44864|0 |1 is obsolete| | Attachment #44865|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 49579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49579&action=ed… Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1 A new element <attributes> will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=1&sh… The output XML should have an element named 'attributes' containing the data you entered. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13216] fix koha-shell to work with git/dev installs
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43446|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 49578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49578&action=ed… Bug 13216 - fix koha shell to accept alternative perl5lib paths To test: gitify an install run sudo koha-shell instance run env | grep PERL5LIB it should be set to /usr/share/koha/lib run sudo koha-shell -d /path/to/your/git/install run env | grep PERL5LIB it should be set to /path/to/your/git/install Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13216] fix koha-shell to work with git/dev installs
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko(a)abunchofthings.net --- Comment #22 from Mirko Tietgen <mirko(a)abunchofthings.net> --- 16044 is in master now. So the first patch of this set is obsolete? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jesse Weaver from comment #12) > I strongly believe that for consistency with the rest of Koha (and due to > frustrations that changing the autogenerated schema files causes), that the > sub allows_add_by should be moved to a Koha:: module. The code has no tie to > the uploaded_files table anyway. Hi Jesse, I am all for consistency. But I moved this sub here instead of Upload.pm because it does not really fit into Upload's object design. Felt like polluting.. Not sure what frustrations you exactly mean, but imo they should not be a reason to block this patch. The custom section of the Results modules should be regenerated each update. The tie to the table is indirect but clear: the sub functionally determines if you have permission to add to the table. > Koha::UploadedFiles might be a good name, as that could later easily become > a Koha::Objects subclass, but that's just a suggestion. I referred to the Object[s] in the commit message, but doing the whole exercise was out of scope here. And just adding it for one sub did not attract me. So I am not convinced that we should move it. But if you really insist, I'd rather move it to Upload.pm or so? -- You are receiving this mail because: You are watching all bug changes.

1 0