March 2016 - Koha-bugs - lists.koha-community.org

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko(a)abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #48 from Mirko Tietgen <mirko(a)abunchofthings.net> --- I tried this, and I see the scripts having version numbers, but they are part of the file name and so they all throw 404s. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14441] TrackClicks cuts off/breaks URLs
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan(a)bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #13 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14441] TrackClicks cuts off/breaks URLs
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Rebased - fixed conflict with the recent security fix in the first patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14441] TrackClicks cuts off/breaks URLs
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49557&action=ed… Bug 14441: TrackClicks cuts off/breaks URLs (XSLT) Same test plan as previous patch, but for opac defail and result using the XSLT views. Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> I am amazed! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14441] TrackClicks cuts off/breaks URLs
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48486|0 |1 is obsolete| | Attachment #48522|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49556&action=ed… Bug 14441 - TrackClicks cuts off/breaks URLs to test... 1/ set TrackClicks syspref to 'track' 2/ add a problematic multipart url to an item's 'url' field example url: http://foo.corg?key1=val1&key2=val2 3/ test url in opac-detail.pl - url is corrupt 4/ apply patch - url is corrct Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> Only fixes the item URLs - a follow-up for the URLs in the bibliographic record (856 for MARC21) is still needed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '16

25 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Mirko Tietgen from comment #10) > Works as advertised. > > One question: without upload_manage permission users are able to delete the > files they uploaded themselves. I suppose that is intended, but it was not > explicitly mentioned in the test plan. Is it the intended behaviour? Thx for testing. Yes, it is intended. (I wrote it in the first commit message, maybe should have been more explicit). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Works as advertised. One question: without upload_manage permission users are able to delete the files they uploaded themselves. I suppose that is intended, but it was not explicitly mentioned in the test plan. Is it the intended behaviour? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49261|0 |1 is obsolete| | --- Comment #9 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 49554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49554&action=ed… Bug 14686: Add Upload to Tools menu This patch makes sure that the added granular permissions work as advertised. Note: The field owner was not included in the Koha::Upload->get response. The code to verify if a user is allowed to delete an upload, is concentrated in the template now. When get returns a Koha::Object, this check could be relocated. Test plan: [1] Verify that the current user has permission for tools, or has at least upload_general_files. [2] Do you see Upload in the Tools menu? Follow the link. [3] Upload a permanent file (with a category). [4] Do you see the Delete button in the results form? [5] Make sure that another user has no permission to upload. [6] Login as that user and check the Tools menu. Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl You should have no access to the upload form. [7] Enable upload_general_files for this user. Go to upload and search for the upload from step 3. You should not see a Delete button. [8] Enable upload_manage for this user. Search for the upload again. Delete the upload. [9] Go to upload via the Cataloguing editor (856$u plugin) or add parameter "plugin=1" to the URL. You should not see the Tools menu. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49260|0 |1 is obsolete| | --- Comment #8 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 49553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49553&action=ed… Bug 14686: Add two granular permission for upload under tools [1] Upload_general_files This will allow you to access the tools/upload form via the Tools menu. And it will also allow you to add permanent uploads. [2] Upload_manage It will allow you to delete uploads from other users. Note that anyone may delete his own uploads. It is not meant to include upload_general_files. In order to not disturb existing users that now have edit_catalogue and are using the plugin (read: added at least one record to uploaded_files), we will add the first permission for them. New users will need to be authorized in the usual way thereafter. Note: If you only have one of the other permissions checked in allows_add_by, e.g. stage_marc_import, you can add temporary uploads, but not permanent uploads. Test plan: We are only testing the dbrev here, not if the perm works as advertised. [1] Run the dbrev and check that you see the perms with a description on the Patron/Set permissions page. [2] If you had records in uploaded_files and a user with edit_catalogue *only*, verify that this user now also has upload_general_files. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49257|0 |1 is obsolete| | --- Comment #7 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 49552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49552&action=ed… Bug 14686: Add allows_add_by to check permissions for uploading The three permissions in tools/upload-file.pl are moved to a custom routine in DBIx's UploadedFile.pm. An additional granular permission upload_general_files is added. (The dbrev patch will contain it too.) At some point in time this could be moved to a Koha::Object class. The routine is tested in Upload.t. Test plan: [1] Run t/db_dependent/Upload.t [2] If you only apply this patch, you can also test uploading with a user that has edit_catalogue but does not have tools or circulate. Upload status should say: Denied. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

1 0