March 2016 - Koha-bugs - lists.koha-community.org

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- I think this should be "Failed QA" until a solution is available which makes the button functional on all pages with that toolbar. Prompted by Bug 16125 I was working on a patch very similar to this one. I can finish it up and post it as an alternative, or drop it if I'm stepping on toes again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13371] Add filters to the supplier list view
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #56 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Tried on sandbox : Some problems occurred applying patches from bug 13371: <h1>Something went wrong !</h1>Applying: Bug 13371: Add filters on the supplier list view Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt Failed to merge in the changes. Patch failed at 0001 Bug 13371: Add filters on the supplier list view -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15413] Adding colons where they should appear in forms etc to be consistent
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45921|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 49531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49531&action=ed… [SIGNED-OFF] Bug 15413: Adding colons where appropriate To test: Apply patch and go to pretty much every page on the Intranet - look out for labels on forms etc where there should be colons but aren't. If you see any that I've missed but I'm 99% sure I got all of them! Make sure to click through some forms where creating a new thing involves continuing the submission on multiple pages. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Rebased on current master and checked all changed pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15413] Adding colons where they should appear in forms etc to be consistent
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11870] Add more informations to histsearch.pl results
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 --- Comment #5 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Owen Leonard from comment #4) > (In reply to Jonathan Druart from comment #3) > > Julian, there is a "searchable" flag in the additional_fields table, I think > > you should use it to know if we want to display fields in the search form. > > Does this comment change whether this bug is ready for signoff? I don't think so, as the patch only display more data in results. It doesn't change the form. Jonathan, are you suggesting we *have to* display these searchable fields in the form ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11870] Add more informations to histsearch.pl results
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Jonathan Druart from comment #3) > Julian, there is a "searchable" flag in the additional_fields table, I think > you should use it to know if we want to display fields in the search form. Does this comment change whether this bug is ready for signoff? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14614] Multiple URLs (856) in cart/list email are broken
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49529|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 49530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49530&action=ed… [SIGNED-OFF] Bug 14614: Multiple URLs (856) in cart/list email are broken To reproduce: - Add multiple subfields 856 u to a bilbio - Add this biblio to a cart and send it as mail (from Staff client and from OPAC) Result: Links in mail body are broken To test - Apply patch - Send carts again (from Staff client and from OPAC) - Result: In mail body, links display separated with blank-pipe-blank like http://bla.com | http://blabla.com | http://blablabla.com - Change one of the 856 u to not to be a link, e.g. äöü - Send carts again - Verify that in mail body äöü correctly display as text. (Amended to make it work for OPAC as well, MV) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14614] Multiple URLs (856) in cart/list email are broken
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '16

24 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0