March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15527] OAI-PMH should have a stylesheet to aid usability
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46459|0 |1 is obsolete| | Attachment #49414|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 49451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49451&action=ed… Bug 15527: Add a stylesheet for OAI-PMH to aid usability This patch introduces an XSLT file grabbed from DSpace and a couple css files. To test: - Point to your dev Koha's oai endpoint. For example: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListMetadataFormats => FAIL: Look how ugly it is for humans. - Apply this patch - Reload => SUCCES: It is styled and provides really useful links to interact with the OAI server verbs. - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Frédéric Demians <f.demians(a)tamil.fr> Works as described. Nice looking. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15527] OAI-PMH should have a stylesheet to aid usability
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16125 Depends on|16125 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 [Bug 16125] Regression: Can't add messages at checkout if no other messages are present -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15163] Patron attributes with branch limiits are not saved when invisible
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have not tested this patch, just fixed the conflict. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15163] Patron attributes with branch limiits are not saved when invisible
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 49448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49448&action=ed… [3.20.x] Bug 15163: Do not erase patron attributes if limited to another library The patron attributes displayed on editing a patron are not displayed if limited to another library. C4::Members::Attributes::SetBorrowerAttributes will now only delete attributes the librarian is editing. SetBorrowerAttributes takes a new $no_branch_limit parameter. If set, the branch limitations have not effect and all attributes are deleted (same behavior as before this patch). Test plan: 1/ Create 2 patron attributes, without branch limitations. 2/ Edit a patron and set a value for these attributes 3/ Limit a patron attributes to a library (one you are not logged in with). 4/ Edit again the patron. => You should not see the limited attributes 5/ Edit the patron attributes and remove the branch limitation => Without this patch, it has been removed from the database and is not displayed anymore. => With this patch, you should see it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #175 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Julian Maurice from comment #174) > (In reply to Jonathan Druart from comment #112) > > Created attachment 48727 [details] [review] [review] > > Bug 11998: Make HoldsQueue.t tests pass [TO REVERT] > > > > This patch should not be the way to make these tests pass. > > The prefs should not be updated using set_preference, it will modify the > > values in the cache. > > > > I have no idea how to make them pass using the correct way, please help > > :) > > Maybe it's because the mocked preference sub is case sensitive (not verified) > A patch fixes that on bug 16134 No, I have just checked and reverted the commit makes the tests failing on top of bug 16134. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch --- Comment #5 from Marc Véron <veron(a)veron.ch> --- (In reply to Blou from comment #4) > Hello Cate, > We'll need your help on that. You see, we cannot reproduce the situation > without hacking the code. It arose because we're adding an extra column in > there for ebooks, in a custom development. It causes a jqury message to pop > up in the UI because of the imbalance in column count. > > The origin of it is commit 6d32d66f, by bug #7720. You can see in there > that it's missing the javascript part for the test. > > So, not sure how to test it. Except that by looking at the code (and 7720's > code), it's "obvious". Just need a way to translate it into a scenario... Blou, Maybe you could add a separate patch with the "hack" that is necessary for testing (marked with something like FOR TESTING ONLY - DO NOT PUSH) The scenario would then be something like: - apply the "Hack" patch - verify the bug - apply the patch with the jQuery fix - verify that the error is gone - remove both patches and apply the jQuery fix patch only - verify that nothing is broken - sign-off the patch with the jQuery fix Marc -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15009] Planning dropdown button in aqbudget can have empty line
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com Status|Signed Off |Failed QA --- Comment #12 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- It is ok, but we need regression tests. Also, please mark it targets master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7594] Google Cover Javascript contains hardcoded CSS style
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7594 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49430|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49440&action=ed… Bug 7594: Google Cover Javascript contains hardcoded CSS style The JavaScript which handles the display of Google book cover images includes a hard-coded "style" attribute. It may have been relevant to the design of the old prog template, but it doesn't seem to have any use in the Bootstrap one. This patch removes it. I have replaced the style attribute with a class in case someone needs a hook for some custom CSS. To test, apply the patch, enable the GoogleJackets system preference, and clear your browser cache if necessary. - Search for a title in the OPAC which has a Google book cover image associated with it. - View the detail page for that title. Confirm that the "Google Preview" link underneath the cover image looks correct. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7594] Google Cover Javascript contains hardcoded CSS style
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7594 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0