March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15119] Hide search header text boxes on render
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #18 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16066] New: JavaScript error on new patron form when duplicate is suspected
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16066 Bug ID: 16066 Summary: JavaScript error on new patron form when duplicate is suspected Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/memberentry.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com JavaScript on the patron add/edit form uses "document.form" to find the value of a form field on the page: var age = CalculateAge(document.form.dateofbirth.value); If you have tried to save a patron which is suspected to be a duplicate, the template defines the <form> without a name attribute and thus the value of dateofbirth cannot be found. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 14582] OPAC detail shows an unuseful link to "add tag" when user is not logged in
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14582 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14582] OPAC detail shows an unuseful link to "add tag" when user is not logged in
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14582 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49396|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron(a)veron.ch> --- Created attachment 49431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49431&action=ed… Bug 14582 - OPAC detail shows an unuseful link to "add tag" when user is not logged in This patch rearranges some parts of the OPAC detail page template so that the "add tag" link does not appear if the user is not logged in. This patch also includes some whitespace changes, so please diff accordingly. To test, apply the patch and set "TagsEnabled" to "Allow." - With "TagsInputOnDetail" set to "Allow," view the detail page for a bibliographic record in the OPAC when /not/ logged in. You should see a "Log in to add tags" link which triggers the login modal when clicked. - Log in and view the same page. Confirm that there is now an "Add tag(s)" link which triggers the add tags form. Confirm that the behavior of the add tags form is still correct. - With "TagsInputOnDetail" set to "Don't allow" view the detail page again and verify that the "Log in to add tags" link doesn't appear when not logged in, and the "Add tags" link doesn't appear when logged in. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16053] New: Edit the active currency removes its 'active' flag
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Bug ID: 16053 Summary: Edit the active currency removes its 'active' flag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15084 >From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 7594] Google Cover Javascript contains hardcoded CSS style
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7594 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7594] Google Cover Javascript contains hardcoded CSS style
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7594 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49413|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron(a)veron.ch> --- Created attachment 49430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49430&action=ed… Bug 7594 - Google Cover Javascript contains hardcoded CSS style The JavaScript which handles the display of Google book cover images includes a hard-coded "style" attribute. It may have been relevant to the design of the old prog template, but it doesn't seem to have any use in the Bootstrap one. This patch removes it. I have replaced the style attribute with a class in case someone needs a hook for some custom CSS. To test, apply the patch, enable the GoogleJackets system preference, and clear your browser cache if necessary. - Search for a title in the OPAC which has a Google book cover image associated with it. - View the detail page for that title. Confirm that the "Google Preview" link underneath the cover image looks correct. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16012] New: The default authority type is not editable
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16012 Bug ID: 16012 Summary: The default authority type is not editable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 15380 Bug 15380 introduced a regression on the authority types admin page: the default authority type (authtypecode="") is no longer editable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1 -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 16015] New: Cannot delete a group of libraries
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 Bug ID: 16015 Summary: Cannot delete a group of libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 15294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 16010] New: merge_authorities migration script is broken
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '16

23 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16010 Bug ID: 16010 Summary: merge_authorities migration script is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15381 Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2 you will get: Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl line 58. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes.

1 11