March 2016 - Koha-bugs - lists.koha-community.org

[Bug 14828] Move the item types related code to Koha::ItemTypes
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16114 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16114 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 [Bug 16114] Regression: Bug 14828 broke display of localized item type descriptions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #171 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #170) > If that's the problem - what would be the fix? What's the value of CACHING_SYSTEM? If it's 'fastmmap', set it to 'memcached' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #170 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- If that's the problem - what would be the fix? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #169 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Katrin Fischer from comment #168) > This morning my OPAC is broken and git bisect leads to this bug. I am using > a local git installation using localhost for the OPAC. Staff on > localhost:8080 seems ok. The error shown is: > > Software error: > > DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Access > denied for user 'www-data'@'localhost' (using password: NO) at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1398. at > /home/katrin/kohaclone/Koha/Database.pm line 90 Bug 16067, perhaps ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #31 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 49121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49121 Bug 12461 - Add patron clubs feature Review of attachment 49121: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=124…) ----------------------------------------------------------------- Did a first code review - not a lot of findings and mostly minor. Haven't tested the code yet. Patch doesn't apply atm - not sure why the modules appear in the general syspref.pm? <<<<<<< HEAD use C4::Log; ======= use Koha::Clubs; use Koha::Club::Enrollments; >>>>>>> Bug 12461 - Add patron clubs feature ::: Koha/Template/Plugin/AuthorisedValues.pm @@ +30,4 @@ > > sub Get { > my ( $self, $category, $selected, $opac ) = @_; > + warn "GET( $self, $category, $selected, $opac )"; Unconditional warn - please remove. ::: koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt @@ +32,5 @@ > +<div class="yui-t7"> > + <div class="yui-main"> > + [% IF stored %] > + <div class="alert"> > + <p>Your club was [% IF stored == 'updated' %] updated [% ELSE %] saved [% END %]</p> Please avoid constructing sentences like that - it's hard to translate, because grammar and work order is different in other languages. ::: koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt @@ +23,5 @@ > + } )); > + }); > + > + function ConfirmDeleteTemplate( id, name, a ) { > + if ( confirm( _("Are you sure you want to delete the club template") + name + "?" ) ) { It would be nicer for translations to use the new Javascript syntax with placeholders here. @@ +41,5 @@ > + } > + } > + > + function ConfirmDeleteClub( id, name, a ) { > + if ( confirm( _("Are you sure you want to delete the club ") + name + "?" ) ) { Same as above - placeholders preferrable! ::: koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt @@ +9,5 @@ > +//<![CDATA[ > + > +function CheckForm() { > + if ( !$("#club-template-name").val() ) { > + alert( _("Name is a required field!") ); Would it be possible to use the standard markup for required fields insted here? See administration pages for examples. @@ +30,5 @@ > +<div class="yui-t7"> > + <div class="yui-main"> > + [% IF stored %] > + <div class="alert"> > + <p>Your club template was [% IF stored == 'updated' %] updated [% ELSE %] saved [% END %]</p> Please don't construct sentences (see above). ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt @@ +27,5 @@ > + </li> > + [% END %] > + > + <li> > + <a href="#" class="btn" onclick="addEnrollment(); return false;"><i class="icon-plus"></i> Enroll</a> Switch to FA icon - I saw most of them were already, maybe missed this one? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11565] decreaseLoanHighHolds needs Override
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11565] decreaseLoanHighHolds needs Override
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49409&action=ed… Screenshot of the suggested addition to the checkout screen We have been adding a lot of elements to the once simple checkout area - I'd like to get Owen's and possible others opinions on how to handle this. A German translation of the text for example would also be longer than the English one and break the display a bit. This might also happen for other languages, that need more words/characters. The new checkbox will only show up when the preference is enabled, which is good. But it currently can't be hidden easily, as the label is missing an id/class. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11565] decreaseLoanHighHolds needs Override
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 48679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48679 Bug 11565 - decreaseLoanHighHolds needs Override Review of attachment 48679: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=115…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +207,5 @@ > <div class="dialog message">The patron has unpaid charges for holds, rentals etc of [% alert.OTHER_CHARGES %]</div> > [% END %] > > +[% IF alert.HIGHHOLDS %] > + <div class="dialog message">High demand item. Loan period <i>not</i> shortened to [% alert.HIGHHOLDS.duration %] days (due [% alert.HIGHHOLDS.returndate %]) due to override.</div> Please avoid the <i> mark-up as this will split the string into several parts in translation and cause issues for translators. Variables are handled with placeholders, so those are no problem. If that remains the only issue, I can fix it in a quick QA follow-up by removing the <i>. Will continue testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11371] Add a new report : Orders by budget
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #40 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- ... even if it might not _look_ like it... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11371] Add a new report : Orders by budget
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0