March 2016 - Koha-bugs - lists.koha-community.org

[Bug 11371] Add a new report : Orders by budget
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #39 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 45982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45982 Bug 11371 - Add a new report : Orders by budget Review of attachment 45982: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- I feel we are getting closer with this, even if it might not feel like it. Can you please take a look at my new comments and the one Jonathan has made? There is one additional thing not noted in the splitter comments: The new report should also be added to the reports module navigation (I think it's reports-menu.inc), that shows up on the left side once you have opened a reports page. ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt @@ +38,5 @@ > + <thead> > + <tr> > + <th>Fund</th> > + <th>Basket</th> > + <th>Basket Name</th> Please fix capitalization in the list of column names. We have agreed that only the first word should be capitalized. @@ +42,5 @@ > + <th>Basket Name</th> > + <th>Basket By</th> > + <th>Title</th> > + <th>Currency</th> > + <th>Vendor Price</th> Please use list price to match acquisition terminology. ::: reports/orders_by_fund.pl @@ +26,5 @@ > +=cut > + > +use strict; > +use warnings; > + Please use Modern::Perl. @@ +111,5 @@ > + > + # Format the dates and currencies correctly > + $order->{'datereceived'} = Koha::DateUtils::output_pref(Koha::DateUtils::dt_from_string($order->{'datereceived'})); > + $order->{'entrydate'} = Koha::DateUtils::output_pref(Koha::DateUtils::dt_from_string($order->{'entrydate'})); > + $order->{'listprice'} = sprintf( "%.2f", $order->{'listprice'} ); It would be nicer to handle the display on template level with the new Price TT plugin. @@ +221,5 @@ > + foreach my $thisbudget ( sort {$a->{budget_name} cmp $b->{budget_name}} @non_active_budgets ) { > + my $budget_period_desc = C4::Budgets::GetBudgetPeriodDescription($thisbudget->{budget_id}); > + my %row = ( > + value => $thisbudget->{budget_id}, > + description => "[i] ". $thisbudget->{budget_name}, The [i] is a translation issue. I think as it's in the template now it's not translatable at all, but I would also prefer another way of displaying it, as [i] is not very clear and will probably cause confusion for translators. Looking in other spots of the acquisition module I have some suggestions: - Don't show the inactive funds to begin with, but only, when a checkbox is checked (see neworderempty.pl) and then put (inactive) behind the inactiv fund name. - Use a hierarchical display for more than one budget and it's funds like on histsearch.pl ::: t/db_dependent/Budgets.t @@ +2,2 @@ > use Modern::Perl; > +use Test::More ; Please don't remove the number of tests to run. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #168 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This morning my OPAC is broken and git bisect leads to this bug. I am using a local git installation using localhost for the OPAC. Staff on localhost:8080 seems ok. The error shown is: Software error: DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Access denied for user 'www-data'@'localhost' (using password: NO) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1398. at /home/katrin/kohaclone/Koha/Database.pm line 90 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15421] Show all available actions in reports toolbar
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan(a)bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '16

22 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #21 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- No, I must admit. In my defence this one came out before it. On the bright side, 16044 covers my first patch, so once 16044 gets accepted, I will just drop the first patch. You may wish to block this bug, but I sincerely doubt that this will move before 16044 and cause trouble. Or alternatively I can make it dependant on that patch, but not sure how "final" it is, ie how heated is the discussion. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '16

21 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #16 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- *** Bug 16119 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16119] New: Single hold request for first available on multiple bibs
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '16

21 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16119 Bug ID: 16119 Summary: Single hold request for first available on multiple bibs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com It would be great (and innovative) if Koha had the ability to place a request on a group of bibs. The concept is that you have a title in multiple formats. The patron doesn't care if they get the regular book, large type, or audio. But these items may be filed in separate bibs. Or maybe there are different editions or prints, and they don't care which they get first. Right now, if you place a hold on these different items, you'll likely get an item from several bibs before you can delete the others. What if the request could be on a group of bibs, and when an item from any of those bibs fills the request, the request goes away? Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 15516] Allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '16

21 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org --- Comment #15 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- *** Bug 15914 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '16

21 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49223|0 |1 is obsolete| | --- Comment #18 from Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> --- Created attachment 49406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49406&action=ed… Bug 15534 - Add the ability to prevent a patron from placing a hold on a record with available items Some libraries would like to prevent patrons from placing holds on items where there are other items available for the patron to check out. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circulation rules 4) Note the new option for "On shelf holds allowed" 5) Set the rule to "If all unavailable", set "item level holds" to allow 6) Find a patron/branch/itemtype applicable to this rule 7) Ensure at least one item on the record is available for the patron to check out 8) Attempt to place a hold for the item 9) Note you cannot place the hold 10) Check the available item out to another patron 11) Note you can now place a hold for the first patron Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> Works as intended! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '16

21 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '16

21 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #65 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This is a bug with a long history :( And it currently doesn't apply, please fix: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 7957: Routing lists enhancements Using index info to reconstruct a base tree... M C4/Items.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview-slip.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt M members/routing-lists.pl Falling back to patching base and 3-way merge... Removing serials/routing.pl Removing serials/routing-preview.pl Removing serials/reorder_members.pl Auto-merging members/routing-lists.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt left in tree. CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt left in tree. Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview-slip.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview-slip -- You are receiving this mail because: You are watching all bug changes.

1 0