April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14050] Default framework for authorities should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14050 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Julian Maurice from comment #32) > Created attachment 50142 [details] [review] > Bug 15126: Update patron definition Julian, I think we need tests to make sure the swagger file will be always up-to-date with the DB structure. Any ideas how we could do that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #107 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #106) > I'm abandoning this bug. It went too far. C'mon!!! :) Question 1 on comment 102 was > C4/Circulation.pm > 1868 my $biblio = $item_level_itypes ? undef : GetBiblioData( $item->{ > biblionumber } ); # don't get bib data unless we need it > > Should not we use GetBiblioItemByBiblioNumber instead to avoid 2 left joins > per return? If you think I am right, I can provide a patch for that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen(a)gmail.com |koha-bugs(a)lists.koha-commun | |ity.org --- Comment #106 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- I'm abandoning this bug. It went too far. All warnings raised by this patchset (on another tests) are just proof that the tests scenarios the other tests used, were missing things (define an itemtype for a created item, for instance). Those are all new bugs that need to be filled. I filled one and provided a patch. But this is really out of the scope of this bug. If someone fills those bugs, I will try to help fixing them. But I'm leaving this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Mason James from comment #5) > (In reply to Jonathan Druart from comment #4) > > I don't understand, on both interface I do not get the "no image" amazon > > image if [OPAC]LocalCoverImages prefs are set. > > Please detail how you get the before/after pic > > Jonathan, do you have 'AmazonCoverImages' enabled? yes > also, the bug only exists in staff interface, and (afaik) 'LocalCoverImages' > syspref is not related to this bug I have: MariaDB [koha]> select variable, value from systempreferences where variable like "%coverimages%"; +-------------------------+-------+ | variable | value | +-------------------------+-------+ | AmazonCoverImages | 1 | | LocalCoverImages | 1 | | OPACAmazonCoverImages | 1 | | OPACLocalCoverImages | 1 | | SyndeticsCoverImages | 0 | | SyndeticsCoverImageSize | MC | +-------------------------+-------+ On master, I have set a local cover image for 1 record and not for another one. Launch a search, I get the local cover image for the first record and the "No cover image available" for the other one. Switching off LocalCoverImages, I get the amazon "No image available" image -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #17 from M. Tompsett <mtompset(a)hotmail.com> --- Switching to signed off, since the sign off pre-dated the busting by bug 12267 requiring the schema files to be regenerated. ./misc/devel/update_dbix_class_files.pl -db_name=koha_library -db_user=... -db_passwd=... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50538|0 |1 is obsolete| | --- Comment #16 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 50538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50538 [SIGNED-OFF]Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t Compile time vs. Run time error checking. Not really a good solution. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 --- Comment #15 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #14) > So should the first patch be obsoleted? > > If I apply the 2 last patches, then: > % perltidy t/db_dependent/Auth_with_ldap.t > % perltidy --profile=xt/perltidyrc t/db_dependent/Auth_with_ldap.t > % diff t/db_dependent/Auth_with_ldap.t{,.tdy} | wc -l > I get 186 So, I retested. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267#c19 Yes, I'll obsolete it. And lastly, I didn't use that perltidyrc. I used whatever is default in Debian 8, such that the errors in perlcritic -1 where ones I didn't care about and it didn't complain about being untidy. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart(a)bugs.koha-c |bouzid.fergani(a)inlibro.com |ommunity.org | Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #64 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50652&action=ed… Bug 12528: redirect to 404 if at least 1 pref is off -- You are receiving this mail because: You are watching all bug changes.

1 0