April 2016 - Koha-bugs - lists.koha-community.org

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '16

26 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50292|0 |1 is obsolete| | --- Comment #241 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Comment on attachment 50292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50292 Bug 12478 Increasing test Coverage for Koha::SearchEngine::Elasticsearch::Search Branch is now up to date -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '16

26 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #23 from Nick Clemens <nick(a)bywatersolutions.com> --- Moved button and fixed case Restricted whitespace to affected lines (and set my git user.name and user.email) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50414|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50666&action=ed… Bug 3534 - (QA followup) whitespace fixes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50413|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50665&action=ed… Bug 3534 - Patron quick add form This patch adds a new system preference: PatronQuickAddFields When either this pref or BorrowerMandatoryField is populated this will add a new dropdown to the bew patron toolbar. When a category is chosen from this dropdown the fields in PatronQuickAddFields and BorrowerMandatoryField will be displayed. There will be a button allowing a user to switch from the quickadd to the full form and fields will be copied between the forms when toggling. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields and note the new button for adding a patron 5 - Click the Quick add and choose a type 6 - Only required or quick add fields should be displayed 7 - Verify toggling forms copies information 8 - Ensure you cannot save patron without filling required fields (quick add fields should be optional) 9 - Ensure you can save patron with fields filled out 10 - Ensure that a duplicate patron brings up the duplicate/add new buttons with full form displayed 11 - Verify that subsequent edits use only full form 12 - Verify that data on form submitted is the data saved to patron 13 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48259|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50663&action=ed… Bug 14576 - Unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48258|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50662&action=ed… Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '16

25 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #20 from Owen Leonard <oleonard(a)myacpl.org> --- I suggested on IRC the separate button menu for "Quick add" because the version of the patch I tested made the quick add action default if PatronQuickAddFields were defined. I thought it was important that staff be able to choose to do a full add if they chose to. The two buttons do look awkward, though. Maybe that wasn't a good idea. I'm not sure what the solution is. I'm going to The quick add button should at least be next to the "New patron" button. And the mixed case on the button label should be corrected. As for the second patch, it makes changes to far more than the 4 line required by the QA tools. We should correct whitespace on changed lines, not all lines. -- You are receiving this mail because: You are watching all bug changes.

1 0