April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I also see older style calls in catalogue/detail.pl and opac/opac-detail.pl that using the details style sheet. Should those be updated as well? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle(a)bywatersolutions.com --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Doesn't opac/opac-tags.pl need to be updated for the new API as well? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14834] Make membership_expiry cronjob more flexible
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #8) > (In reply to Bernardo Gonzalez Kriegel from comment #6) > > New parameters work with one (-) or two(--) dashes, no problem > > with that but convention suggest that 'long' options use two-dashes. > > Did not really look at that. Just expanded on what was there. > Could be that we need something like o|option to make that work.. Found out that this can be arranged (more or less) with: $Getopt::Long::bundling = 1; But note that we never used this in the Koha codebase. So I guess this patch should not start it.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14834] Make membership_expiry cronjob more flexible
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Bernardo Gonzalez Kriegel from comment #6) > New parameters work with one (-) or two(--) dashes, no problem > with that but convention suggest that 'long' options use two-dashes. Did not really look at that. Just expanded on what was there. Could be that we need something like o|option to make that work.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15543] Use another notice in membership_expiry.pl
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46766|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 50459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50459&action=ed… [SIGNED-OFF] Bug 15543: Use another notice in membership_expiry.pl This patch adds a letter parameter to the cron job membership_expiry. It is used to substitute the default notice by another one. This could be handy if you e.g. send a reminder after the first notice. In any case, it allows for more flexibility. Apart from this new parameter, this patch removes the sub parse_letter from the code. The call to GetPreparedLetter is moved to the for loop and the call to getletter is removed (no longer needed). If there is no letter found, the Letter module already warns you. So we just exit the loop. Test plan: [1] Run membership_expiry.pl -c -n -v -let NOT_EXIST Check if you see a warning (coming from Letters.pm) [2] Check if you have some soon expiring patrons or add before/after parameter to include some. Run membership_expiry.pl -c -n -v [-before ?] [-after ?] [3] Create a new notice MEMBERSHIP2. Copy the text from the original notice and make some adjustments. [4] Run membership_expiry.pl -c -v -let MEMBERSHIP2 [-before ?] [-after ?]. Be aware that this call generates email messages. Verify that the email contained the adjusted text. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> On top of Bug 14834 Work as described, tested using '-n' to see messages on terminal, e.g. membership_expiry.pl -v -n -c -before 3 -branch BC -after 2 --letter MEMEXP2 No errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15543] Use another notice in membership_expiry.pl
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14834] Make membership_expiry cronjob more flexible
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Bernardo Gonzalez Kriegel from comment #6) > Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Thx for your fast reply :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14834] Make membership_expiry cronjob more flexible
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46765|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 50458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50458&action=ed… [SIGNED-OFF] Bug 14834: Make membership_expiry cronjob more flexible This patch adds three parameters to the cron job: -before and -after, and -branch. You can run the cronjob now in an adjusted frequency: say once a week with before 6 or after 6 (not both together). If your pref is set to 14, running before=6 will include expiries from 8 days to 14 days ahead. When you use after=6, you would include 14 days to 20 days ahead, etc. You could also rerun the job of yesterday by setting before=1 and after=-1; this could help in case of problem recovery. Obviously, the branch parameter can be used as a filter. NOTE: Why are these parameters passed only via the command line? Well, obviously the branch parameter is not suitable for a pref. The before/after parameter allows you to handle expiry mails different from the normal scheme or could be used in some sort of recovery. In those cases it will be more practical to use a command line parameter than editing a pref. NOTE: The unit test has been adjusted for the above reasons, but I also added some lines to let existing expires not interfere with the added borrowers by an additional count and using the branchcode parameter. Test plan: [1] Run the adjusted unit test GetUpcomingMembershipExpires.t [2] Set the expiry date for patron A to now+16 (with pref 14). Set the expiry date for patron B to now+11. [3] Run the cronjob without range. You should not see A and B. [4] Run the cronjob with before 3. You should see patron B. [5] Run the cronjob with before 3 and after 2. You should see A and B. [6] Repeat step 5 with a branchcode that does not exist. No patrons. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Work as described following test plan. Test pass No errors New parameters work with one (-) or two(--) dashes, no problem with that but convention suggest that 'long' options use two-dashes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14834] Make membership_expiry cronjob more flexible
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 906] ISBN Check
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 --- Comment #18 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Marjorie Barry-Vila from comment #16) > Is anyone planning on following up on this bug? Until the work flow becomes clearly defined, something can't be written properly, as noted in comment #15. So, I don't think this bug is going to leave Failed QA purgatory, except to be snuffed out with a RESOLVED / WONT FIX, because fixing something without a clear definition doesn't work. -- You are receiving this mail because: You are watching all bug changes.

1 0