April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- (In reply to Kyle M Hall from comment #5) > (In reply to Colin Campbell from comment #4) > > Is this a bit cumbersome? what about starting by passing Log4perl to the > > Net::Server config it already supports it its the Koha calls to syslog that > > stop us enabling it. Coud we not then just call up logger rather than > > passing $self->server about all the time which looks a bit clumsy > > I'm not sure I understand what your saying. Could you expand on this a bit? > > Thanks! ::My Code review about this feature:: I think we should use only one way of logging in Koha. If we have a separate way of defining and calling loggers in Net::Server, then in C4::* , Koha::* then we have Mojo::Log in Mojolicious Server, it gets hard to work with all of them. We should use Koha::Logger with everything. If you don't happen to like the extra securities Kyle imnplemented in Koha::Logger you can easily write your own drop-in replacement for it and Koha won't know the difference, especially since the feature is so well regression tested. Passing the server as a constructor parameter is smart. The other alternative is to define and make sure that the global package-level parameter $currentServer (or equivalent) has its status maintained in all parts of the SIP-server lifecycle. This might get cumbersome and will lead to hard-to-track bugs in the future. This way is explicit and improves the usability of the logging output. ...however... Looking at http://search.cpan.org/~mschilli/Log-Log4perl-1.47/lib/Log/Log4perl/Layout/… and especially "Mapped Diagnostic Context" http://search.cpan.org/~mschilli/Log-Log4perl-1.47/lib/Log/Log4perl.pm#Mapp… ...makes me think that you no longer need to pass the server-handle around to log the mentioned sip2-request data elements. You can just define the MDC when you start processing the transaction (or when you log-in or however the SIP-server worked). The added benefit of using MDC is that you can configure whether or not you want to display the userid or institution or whatnot. This is a must for this kind of generic information. There is only one reasonable way to deal with this issue, and that is to use the MDC and set it when you decide which userid/institution/whatnot is being logged, or you can set the MDC every time you want to log from the server-handle. With MDC the ConversionPattern would look crudely something like this: log4perl.appender.SIP.layout.ConversionPattern=[%d] [%p] [%X{userid}] [%X{institution}] %m %l %n I can imagine in the future there may be other purposes for the server-handle and it is nice to have it accessible. However passing these references around leaves a dreadful possibility of accidentally stumbling upon a circular reference :) "Bug 15253 - Log stderr via Koha::Logger as well" is VERY GOOD <3 <3 <3 Also this feature has the title "Bug 15253 - Add Koha::Logger based logging for SIP2" which doesn't imply passing server as a parameter everywhere and quite frankly in light of this (new for me) MDC workaround, I see no reason to introduce that server-handle passing change here. Also messages are logged twice: 1st with $self->{server}->{logger}->debug(); 2nd syslog("LOG_DEBUG", ...); Log::Log4perl best practice is to invoke it like this: $self->{server}->{logger}->debug() or syslog("LOG_DEBUG", ...); I don't see any reason why we should preserve the old logging code in the SIP2-server at all. Koha::Logger is the way to go! But looks like that is fixed in "Bug 15253 - Remove use of syslog". Also there is a complete lack of tests. You can take a look at Bug 16302 and Bug 16304 for a pretty good testing system for Koha::Logger. Summary: A much needed change, but needs to be simplified a lot using MDC. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 906] ISBN Check
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 --- Comment #17 from Pascale Nalon <pascale.nalon(a)ensmp.fr> --- We, at Mines ParisTech, aren't involved anymore in this bug, because we don't catalog anymore in Koha. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16307] New: OAI-PMH duplicate tag 520 & 521 when export to OAI_DC
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16307 Bug ID: 16307 Summary: OAI-PMH duplicate tag 520 & 521 when export to OAI_DC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: hagud(a)orex.es QA Contact: testopia(a)bugs.koha-community.org When harvest from koha using oai_dc it duplicates tags 520 and 521 we have checked in koha 3.14 and 3.22 and it can be fixed if modify some xsl I guess it is a wrong code, but perhaps there is a reason I do not understand sample record: http://oapn.orex.es/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=oai_d… It fixes if we add not 520 and 521 <xsl:for-each select="marc:datafield[500<@tag][@tag<=599][not(@tag=506 or @tag=520 or @tag=521 or @tag=530 or @tag=540 or @tag=546)]"> <dc:description> <xsl:value-of select="marc:subfield[@code='a']"/> </dc:description> </xsl:for-each> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8352] Add automatic printing of 'hold to pull' notices
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #108 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Chris Cormack from comment #107) > Weird, working fine for me. > > You've asked to be added to the group eh? > http://pkg-perl.alioth.debian.org/ > (Under A note on joining) > > All the docs are on that page. You could try asking on the #debian-perl > channel listed there. They are pretty receptive to helping > > Or you could try to catch jajm on IRC he's usually closer to your timezone > than I am. And has packaged > https://tracker.debian.org/pkg/libtemplate-stash-autoescaping-perl Thanks! I figured out why I couldn't confirm my account ( all new accounts end with -guest and I didn't notice that ). I've requested to be added to the pkg-perl group. I'll check out the docs. Thanks again! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8352] Add automatic printing of 'hold to pull' notices
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #107 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Weird, working fine for me. You've asked to be added to the group eh? http://pkg-perl.alioth.debian.org/ (Under A note on joining) All the docs are on that page. You could try asking on the #debian-perl channel listed there. They are pretty receptive to helping Or you could try to catch jajm on IRC he's usually closer to your timezone than I am. And has packaged https://tracker.debian.org/pkg/libtemplate-stash-autoescaping-perl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8352] Add automatic printing of 'hold to pull' notices
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #106 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Also, when I try to confirm my account on Alioth, all I get is a "user not found" error. So I can't even push the code to Alioth. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8352] Add automatic printing of 'hold to pull' notices
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #105 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Chris Cormack from comment #104) > You've read > https://wiki.koha-community.org/wiki/Building_Debian_Dependencies right? Yep. I'm a bit lost on http://pkg-perl.alioth.debian.org/git.html . There is a bit of hand waving there, the section titled "building the package" has the most helpful guidance: Use your favourite way of building the Debian package. This documentation is simply not clear not understandable. I don't claim to be the brightest bulb there is, but I'd like to think I can follow instructions when they are presented in a reasonable way ; ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14167] Add Koha::Logger based on Log4perl
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16306 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9393] Add note to circulation.pl if borrower has pending modifications
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '16

20 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50452&action=ed… [PASSED QA] Bug 9393 [QA Followup] - Don't display link if librarian cannot view the modification Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0