April 2016 - Koha-bugs - lists.koha-community.org

[Bug 13705] Move indexation subs in C4::ZebraIndex
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Just a general question: why C4 and not Koha? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #49 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Should we move this out of the list for now? "In Discussion" or "Failed QA"? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46263|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50225&action=ed… Bug 11999: Check for age restriction in CanBookBeReserved + improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46262|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50224&action=ed… Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15564] Display "print slip" option when returning an item which is in a rotating collection
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Benjamin Rokseth from comment #10) > Why patch doesn't apply? Applies cleanly for me on master ref > 2a8c68936dd7fd5c82af339db968eb67cb93a082 Yes, sorry about that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15564] Display "print slip" option when returning an item which is in a rotating collection
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 --- Comment #10 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Why patch doesn't apply? Applies cleanly for me on master ref 2a8c68936dd7fd5c82af339db968eb67cb93a082 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13705] Move indexation subs in C4::ZebraIndex
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I would be great to see some tests to cover this new module (even if it's not new code). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #233 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comments about the last 2 patches: 1/ The tests are db dependent, the files should be moved to t/db_dependent 2/ The license part is missing, you have put a custom block instead I think we should have a better test coverage before pushing this work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #48 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #47) > The trick done in Koha::Checkout->item may be dangerous. > Same for Koha::Item->biblio and Koha::Item->biblioitem > You are not fetching the item on each call. That mean you could retrieve an > outdated info in some scenarios. > > The mix between the Koha::Object and DBIx::Class calls is also weird. > > I'd like to get some other QA point of views on this patch set. Does not look good to me too. We should probably not use _new_from_dbic outside Object[s] too. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '16

14 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 [Bug 16258] Add a preference to turn EDIFACT off -- You are receiving this mail because: You are watching all bug changes.

1 0