April 2016 - Koha-bugs - lists.koha-community.org

[Bug 13216] fix koha-shell to work with git/dev installs
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 --- Comment #18 from Owen Leonard <oleonard(a)myacpl.org> --- Thank you very much for the clarified test plan. This looks like it's working. Once piece is missing: What should I be able to do with these patches that I couldn't do before? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- The trick done in Koha::Checkout->item may be dangerous. Same for Koha::Item->biblio and Koha::Item->biblioitem You are not fetching the item on each call. That mean you could retrieve an outdated info in some scenarios. The mix between the Koha::Object and DBIx::Class calls is also weird. I'd like to get some other QA point of views on this patch set. Note that tests are not provided and will be a blocker. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- QA comments: On the whole, this patch is great. Tests are provided and the code is clean and pleasant to read. Great job Alex! 1/ I am wondering if the 2 subroutines in Koha::Patron::CheckPrevIssue should not be methods of Koha::Patron 2/ I think that "Loans"/"Loaned" should be replaced with checkouts/check out (see http://wiki.koha-community.org/wiki/Terminology) 3/ Please provide test coverage for the changes you made in C4::Circulation::CanBookBeIssued 4/ In the update DB entry, please add the "after" clause to make sure the columns will be added at the same place than new installs (kohastructure). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Attachment #50127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13216] fix koha-shell to work with git/dev installs
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50126|0 |1 is obsolete| | --- Comment #17 from Mason James <mtj(a)kohaaloha.com> --- Created attachment 50202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50202&action=ed… Bug 13216 - fix koha-shell to work with git/dev installs The aim of this patch is to enable developers to begin testing Koha tools from a gitified Koha directory, using koha-shell this patch set adds a --gitify arg and a --kohadir arg to koha-shell To test: gitify an install apply both patches, then copy patched koha-shell to /usr/sbin dir run sudo koha-shell instance run env | grep PERL5LIB, it should be set to /usr/share/koha/lib run sudo koha-shell -d /path/to/your/git/install instance run env | grep PERL5LIB, it should be set to /path/to/your/git/install run which koha-list, it should be set to /usr/sbin/koha-list run sudo koha-shell -g -d /path/to/your/git/install instance run env | grep PERL5LIB, it should be set to /path/to/your/git/install run env | grep PATH, it should be set to /path/to/your/git/install/debian/scripts:$PATH run env | grep KOHA_GITIFY, it should be set to 1 run which koha-list, it should be set to /path/to/your/git/install/debian/scripts/koha-list run koha-list, it should work as expected run sudo koha-shell -g instance, it should give error... 'You must supply --kohadir when using --gitify' https://bugs.koha-community.org/show_bug.cgi?id=13295 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmc(a)esilibrary.com, | |gmcharlt(a)gmail.com --- Comment #36 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #33) > Did someone try to package Mojolicious v6 and Swagger2 v0.59 for Jessie? They are both packaged in Debian testing, so it shouldn't be too hard to make a backport for Jessie. But I'll let Galen answer that. Adding Galen to the CC list. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #35 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #34) > What about that suggestion? Olli said: > When you reference a definition, you had to write the reference like this: > "$ref": "/definitions/index.json#/borrowernumber" > > now you can write the reference more easy: > "$ref": "/definitions.json#/borrowernumber" But you can also write (Olli please correct me if I'm wrong) "$ref": "/definitions/borrowernumber.json" So I don't see any benefit in moving index.json -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15564] Display "print slip" option when returning an item which is in a rotating collection
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Olli-Antti Kivilahti from comment #29) > Sure. > > Tho I stress that you should replace > > definitions/index.json > > with > > definitions.json What about that suggestion? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Did someone try to package Mojolicious v6 and Swagger2 v0.59 for Jessie? -- You are receiving this mail because: You are watching all bug changes.

1 0