April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Bouzid <bouzid.fergani(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47142|0 |1 is obsolete| | --- Comment #7 from Bouzid <bouzid.fergani(a)inlibro.com> --- Created attachment 50146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50146&action=ed… Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15533] Allow patrons and librarians to select itemtype when placing hold
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 --- Comment #10 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50145&action=ed… Bug 15533: Fix 'ambiguous' SQL query in CanItemBeReserved Adding reserves.itemtype made a query to fail in CanItemBeReserved. This patch prefixes the column names with the corresponding table names to prevent that. You can trigger the error by running prove t/db_dependent/Holds.t You should see something like this: Column 'itemtype' in where clause is ambiguous -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #217 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Can't index authorities in ES. koha-koha@jessie:/home/koha/koha$ perl misc/search_tools/rebuild_elastic_search.pl -v -a Indexing authorities Can't locate object method "get_all_authorities_iterator" via package "Koha::Authority" at misc/search_tools/rebuild_elastic_search.pl line 151. Not sure why that is the case, there is a sub get_all_authorities_iterator in Koha/Authority.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #32 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50142&action=ed… Bug 15126: Update patron definition -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Please provide an updated patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12267] Allow password option in Patron Attribute non functional
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to M. Tompsett from comment #7) > Comment on attachment 50122 [details] [review] > Bug 12267: Remove borrower_attributes.password > > Review of attachment 50122 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Members/AttributeTypes.pm > @@ +217,3 @@ > > ?, ?, ?, ?, ?, ?)"); > > } > > + $sth->execute( $self->{description}, $self->{repeatable}, $self->{unique_id}, $self->{opac_display}, $self->{staff_searchable}, $self->{authorised_value_category}, $self->{display_checkout}, $self->{category_code} || undef, $self->{class}, $self->{code} ); > > Keeping it vertical would have been easier to read. Patch amended. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12267] Allow password option in Patron Attribute non functional
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '16

12 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50122|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50140&action=ed… Bug 12267: Remove borrower_attributes.password When creating a patron attribute type, there is a "Allow password" checkbox. If checked, the librarian will be able to enter a password for this patron attribute when editing a patron. The goal was to allow a patron to log in with a secondary password. However, this feature has never been implemented. """ commit 6fc62bcd321eddb0fd3ae46903e9ab6c8b1db2cd CommitDate: Mon May 12 09:03:00 2008 -0500 extended patron attributes tables & syspref (DB rev 081) - password_allowed (if set, staff patron editor will allow a password to be associated with a value; this is mostly a hook for functionality to be implemented in the future. """ To decrease maintainability, this patch suggest to remove the 2 DB fields borrower_attributes.password and borrower_attribute_types.password_allowed If they have not used by the library. Test plan: - Edit a patron attribute type and select "allow password" - Edit a patron and defined a password for this attribute - Execute the DB entry - Note that you get a warning - Empty the password field - Execute the DB entry - You do not get the warning and the 2 DB fields have been removed -- You are receiving this mail because: You are watching all bug changes.

1 0