April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14974] Use the REST API for cities
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel(a)gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt Auto-merging api/v1/swagger.json Failed to merge in the changes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #14) > Also in the patch > $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?'; > $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?'; > $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?'; > $query = 'SELECT ' . join(',', @fields) . ' FROM ' . $table . ' > WHERE frameworkcode=?'; > This is present code, not in the patch, sorry. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Hi, testing this. Export works Ok, all formats. Import does not work. I created a new auth type, then 'imported' some of the exported formats, auth_tag_structure and auth_subfield_structure are not populated, instead auth_tag_structure.pl gives you the option to fill fields using another auth_type (after some time). Looking at the logs you find DBD::mysql::st execute failed: Unknown column 'frameworkcode' in 'where clause' [for Statement "DELETE FROM auth_tag_structure WHERE frameworkcode=? AND ... and that's right because, unfortunately, auth tables use authtypecode instead of frameworkcode. Also in the patch $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?'; $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?'; $query = 'SELECT * FROM ' . $table . ' WHERE frameworkcode=?'; $query = 'SELECT ' . join(',', @fields) . ' FROM ' . $table . ' WHERE frameworkcode=?'; Aditionally there are a few tabs that must be removed, FAIL C4/ImportExportFramework.pm OK critic FAIL forbidden patterns forbidden pattern: tab char (line 234) forbidden pattern: tab char (line 285) forbidden pattern: tab char (line 236) forbidden pattern: tab char (line 235) forbidden pattern: tab char (line 237) forbidden pattern: tab char (line 232) forbidden pattern: tab char (line 233) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16082] New: Empty patron detail page is displayed if the patron does not exist - circulation.pl
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Bug ID: 16082 Summary: Empty patron detail page is displayed if the patron does not exist - circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com On circulation.pl, an empty patron detail page is displayed if the patron does not exist. A friendly message should be displayed instead. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #22 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50128&action=ed… Bug 6906 - show 'Borrower has previously issued... New feature: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their loan history. - Global syspref ('CheckPrevIssue'), set to 'hardno' by default, allows users to enable this feature library wide. - Per patron category pref allows libraries to create overrides per category, falling back on the global setting by default. - Per patron pref allows switching the functionality on at the level of patron. Fall-back to category settings by default. * Koha/Patron/CheckPrevIssue.pm: New file * C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevIssue check. * admin/categories.pl: Pass along checkprevissue. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose CheckPrevIssue per category setting. * koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref: Expose CheckPrevIssue syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Expose per patron CheckPrevIssue preference. * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose per patron CheckPrevIssue preference. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVISSUE' confirmation message. * installer/data/mysql/kohastructure.sql: Modify structure of 'categories', 'borrowers'. * installer/data/mysql/sysprefs.sql: Add 'CheckPrevIssue'. * installer/data/mysql/atomicupdate/checkPrevIssue.sql: New file. * t/db_dependent/Patron/CheckPrevIssue.t: New file with unit tests. Test plan: - Apply patch. - Run updatedatabase. - Regenerate Koha Schema files. - Run the unit tests. - Verify 'CheckPrevIssue' is visible in Patrons sysprefs and can be switched to 'hardyes', 'softyes', 'softno' and 'hardno'. + Check out previously issued items to a patron, checking the message appears as expected. - Verify no 'Check previous loans' setting appears on the borrower category pages if the syspref is set to a 'hard' option. - Verify 'Check previous loans' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting if that is set to a 'soft' option). - Verify no 'Check previous loans' setting appears on the individual borrower pages if the syspref is set to a 'hard' option. - Verify 'Check previous loans' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting if the latter is set to a 'soft' option). Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14546] Make staff client templates responsive
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 [Bug 16239] Upgrade Bootstrap in the staff client -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14546] Make staff client templates responsive
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make staff client use |Make staff client templates |Bootstrap |responsive -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50071|0 |1 is obsolete| | --- Comment #21 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 50127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50127&action=ed… Don't depend on duplicate bug. I now correct my mistake of depending on my own implementation of Koha::Categories, as I discovered that these objects already exist (pushed to master) in the form of Koha::Patron::Categories. This patch uses the latter. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13216] fix koha-shell to work with git/dev installs
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '16

11 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50125|0 |1 is obsolete| | --- Comment #12 from Mason James <mtj(a)kohaaloha.com> --- Created attachment 50126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50126&action=ed… Bug 13216 - fix koha-shell to work with git/dev installs The aim of this patch is to enable developers to begin testing Koha tools from a gitified Koha directory, using koha-shell this patch adds a new --gitify arg to koha-shell, to be used with the new -d option to test new --gitify arg... 1/ apply 1st patch 2/ run a "koha-shell -c 'which koha-*'" on a Koha tool, with -d arg # perl ~/koha-master/debian/scripts/koha-shell -d ~/koha-master -c 'which koha-list ' moof /usr/sbin/koha-list <<<< 3/ observe existing /usr/share/koha/* file is selected, hmm... 4/ apply 2nd patch - and repeat 2/ with --gitify arg # perl ~/koha-master/debian/scripts/koha-shell -d ~/koha-master -g -c 'which koha-list ' moof ~/koha-master/debian/scripts/koha-list <<<< 5/ observe file from the git repo is now selected .-=bonus points, xXxtra merit=-. 6/ run tool to make sure it works # perl ~/koha-master/debian/scripts/koha-shell -d ~/koha-master -g -c 'koha-list' moof ... 7/ run the old tool too # perl ~/koha-master/debian/scripts/koha-shell -c 'koha-list' moof ... -- You are receiving this mail because: You are watching all bug changes.

1 0