April 2016 - Koha-bugs - lists.koha-community.org

[Bug 16020] New: Remove unused CSS and images following label creator UX changes
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '16

08 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16020 Bug ID: 16020 Summary: Remove unused CSS and images following label creator UX changes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Some CSS and images were left behind after Bug 14667, Label creator UI/UX revamp, was pushed. They should be removed. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 16019] New: Remove unused blue.css
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '16

08 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16019 Bug ID: 16019 Summary: Remove unused blue.css Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /intranet-tmpl/prog/en/css/blue.css OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The last time I asked was in 2011 and the staff client was styled very differently then. The last time the file was updated was 2009. Is it safe to delete blue.css now? I don't think we should continue to include a file which is not used by Koha's default configuration. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 14076] Noisy warns in opac-authorities-home.pl
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '16

08 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #15 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '16

08 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47364|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 50046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50046&action=ed… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Click 'Import' into your new authority type (so you don't overwrite any important existing authority types) 7) Select the file you just exported and click 'Import' 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Go to Admin -> MARC bibliographic framework 12) Confirm that the 'Export' and 'Import' functions still work here as well -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '16

08 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '16

08 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49833|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 50044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50044&action=ed… Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar This patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar. EDIT: Ensuring modal opens on all pages EDIT2: Once the form has been submitted the page will redirect to where you submitted the form from. EDIT3: Fixing indentation of member-add-message.inc Ensuring messages save on every page Fill branch Ensure predefined notes appear Form redirects to where it was submitted from, or just the circulation page. EDIT4: Removing the new include file and moving it all into the modal in the toolbar To test: 1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X) 2) Click 'Add a new message' under Messages 3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC. 4) Click Cancel. Confirm this closes the modal. 5) Click 'Add message' button in toolbar. Complete steps 3 and 4. 6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows. circ/circulation.pl members/moremember.pl members/routing-lists.pl members/statistics.pl members/boraccount.pl members/pay.pl members/maninvoice.pl members/mancredit.pl members/readingrec.pl members/notices.pl members/member-flags.pl members/member-password.pl members/paycollect.pl members/files.pl 7) Confirm that the page redirects to where you submitted the form from once you have submitted it. 8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '16

08 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #69 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Hi David, (In reply to David Cook from comment #68) > 6) In Koha, create a record matching rule: > Code = OAI > Match threshold = 100 > Record type = Bibliographic > Search index = control-number > Score = 100 > Tag = 001 > Search index = id-other,st-urx > Score = 100 > Tag = 024 > Subfields = a > Normalization rule = raw does that mean "create two match points with Match point 1 Search index = control-number Score = 100 Tag = 001 Match point 2 Search index = id-other,st-urx Score = 100 Tag = 024 Subfields = a Normalization rule = raw "? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #2 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Nick Clemens from comment #1) NVM - error is below, we loop through each reasonforconfirmation, some of these are borrower fields, when we hit those we print them as the screen message, we should instead check for the presence of any of these reasons and then log failed unknown if not equal and output and error to the screen_msg: 74 foreach my $confirmation (keys %{$needsconfirmation}) { 75 if ($confirmation eq 'RENEW_ISSUE'){ 76 $self->screen_msg("Item already checked out to you: renewing item."); 77 } elsif ($confirmation eq 'RESERVED' or $confirmation eq 'RESERVE_WAITING') { 78 my $x = $self->{item}->available($patron_barcode); 79 if ($x) { 80 $self->screen_msg("Item was reserved for you."); 81 } else { 82 $self->screen_msg("Item is reserved for another patron upon return."); 83 # $noerror = 0; 84 } 85 } elsif ($confirmation eq 'ISSUED_TO_ANOTHER') { 86 $self->screen_msg("Item already checked out to another patron. Please return item for check-in."); 87 $noerror = 0; 88 } elsif ($confirmation eq 'DEBT') { 89 $self->screen_msg('Outstanding Fines block issue'); 90 $noerror = 0; 91 } elsif ($confirmation eq 'HIGHHOLDS') { 92 $overridden_duedate = $needsconfirmation->{$confirmation}->{returndate}; 93 $self->screen_msg('Loan period reduced for high-demand item'); 94 } elsif ($confirmation eq 'RENTALCHARGE') { 95 if ($self->{fee_ack} ne 'Y') { 96 $noerror = 0; 97 } 98 } else { 99 $self->screen_msg($needsconfirmation->{$confirmation}); 100 $noerror = 0; 101 syslog('LOG_DEBUG', "Blocking checkout Reason:$confirmation"); 102 } 103 } 104 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15438] Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Priority|P5 - low |P3 Severity|enhancement |major --- Comment #1 from Nick Clemens <nick(a)bywatersolutions.com> --- Raising the severity, marking as a bug. Repeated messages will return any one of: borrowernumber firstname surname cardnumber reservedate reservebranch I believe in the code below we are just shoving the issuingimpossible hash into screen_msg and ending with any one of the values: [koha.git] / C4 / SIP / ILS / Transaction / Checkout.pm 67 if (scalar keys %$issuingimpossible) { 68 foreach (keys %$issuingimpossible) { 69 # do something here so we pass these errors 70 $self->screen_msg($_ . ': ' . $issuingimpossible->{$_}); 71 $noerror = 0; 72 } 73 } else { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13213|0 |1 is obsolete| | --- Comment #17 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 50043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50043&action=ed… Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date - Add holidays check Signed-off-by: Chris William <chrisw(a)pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.

1 0