April 2016 - Koha-bugs - lists.koha-community.org

[Bug 9387] Feedback message for FAILED check out items are not obvious for visually impaired
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9387 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49989|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron(a)veron.ch> --- Created attachment 50028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50028&action=ed… Bug 9387 - Feedback message for FAILED check out items are not obvious for visually impaired This patch adds a heading to the error dialg displayed when a barcode has been submitted for checkout which doesn't exist. This patch also modifies the markup of the error dialog in order to make error a little more clear to sighted users. To test, apply the patch and submit a barcode for checkout which does not exist. The resulting error dialog should have a heading, "Barcode not found." Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12787] Unit test files should be better organized
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris(a)bigballofwax.co.nz |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12787] Unit test files should be better organized
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787 --- Comment #2 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50027&action=ed… Bug 12787: Reorganise t/db_dependent files This patch tries to reorganise test files in the db_dependent directory: - Circulation_Branch.t has been moved to Circulation/Branch.t - Circulation_issuingrules.t has been moved to Circulation/CalcDateDue.t - Circulation_Issuingrule.t has been moved to Circulation/GetHardDueDate.t - Circulation_dateexpiry.t has been moved to Circulation/dateexpiry.t - Circulation_issue.t has been moved to Circulation/issue.t - Circulation_transfers.t has been moved to Circulation/transfers.t - Items_DelItem.t has been moved to Items/DelItem.t - BiblioObject.t has been moved to Koha/Biblio.t - Members_Attributes.t has been moved to Members/Attributes.t - Members_columns.t has been moved to Members/columns.t - Circulation_OfflineOperation.t has been moved to Circulation/OfflineOperation.t - Koha_template_plugin_KohaDates.t has been moved to Template/Plugin/KohaDates.t - Koha_template_plugin_Branches.t has been moved to Template/Plugin/Branches.t - Reports/Guided.t, ReportsGuided.t and Reports_Guided.t have been merged Test plan: Confirm that all the modified tests still pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12787] Unit test files should be better organized
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #10 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46337|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50026&action=ed… Bug 15395: Add plural translation capabilities to JS files It adds Javascript equivalent of Koha::I18N's exported subroutines, and they are used the same way. String extraction is done only on *.js files and require gettext 0.19 (available in Debian stable, and also in wheezy-backports) It adds Javascript library Gettext.js for handling translation and a Perl script po2json to transform PO file into JSON. Gettext.js and po2json both come from Locale::Simple. There are several tools named po2json. It's simpler to integrate this one into Koha than to check if the good one is installed on the system. Locale::Simple is not needed. To avoid polluting the global namespace too much, this patch also introduce a global JS object named Koha and add some stuff in Koha.i18n Test plan: 1. Add a translatable string in a JS file. For example, add this: alert(__nx("There is one item", "There are {count} items", 3, {count: 3})); to staff-global.js 2. cd misc/translator && ./translate update fr-FR 3. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po, verify that your string is present, and translate it 4. cd misc/translator && ./translate install fr-FR 5. (Optional) Verify that koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and contains your translation 6. Open your browser on the staff main page, change language and verify that the message is translated 7. Repeat 1-6 on OPAC side -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45799|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50025&action=ed… Bug 15395: Example usage of I18N Template::Toolkit plugin -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45798|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50024&action=ed… Bug 15395: Plural translations in templates Provides a way to handle translation of plural forms in templates Add Template::Toolkit plugin for Koha::I18N Use like this: [%# USE the plugin and define some macros %] [% PROCESS 'i18n.inc' %] [%# tn is the equivalent of __n %] [%# macro names can't start with underscore, t is for "translate" %] [% tn('item', 'items', num_items) %] Extraction of strings from templates is a bit complicated and use Template::Parser and PPI. Template is compiled into Perl code and then analyzed by PPI. It is slow, but should be correct even with complex constructions. Add dependency to PPI Test plan: 1. Open a template file (.tt or .inc) with your favorite text editor 2. Add the PROCESS directive mentioned above in the beginning of file 3. Use one of the t* macros defined in i18n.inc. They are used like their "__" equivalent, with one difference: the 'x' variants take a hashref instead of a hash as last parameter 4. cd misc/translator && ./translate update fr-FR 5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your string(s) 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45797|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50023&action=ed… Bug 15395: Allow correct handling of plural translation Locale::Maketext does not allow correct handling of plural translation for languages that have more than one plural forms. Locale::Messages does. So Koha::I18N is now a wrapper around Locale::Messages, just like Locale::TextDomain, and export the same symbols as Locale::TextDomain. You can refer to documentation of Locale::TextDomain to know how to use exported subroutines. The PO file moves from misc/translator/po/xx-XX-messages.po to misc/translator/po/xx_XX/LC_MESSAGES/Koha.po and now needs to be compiled to MO in order to be used by Koha. Compilation of PO file is done by running: ./translate install xx-XX Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon Add dependency to Locale::Messages Test plan: 1. Open a .pl script or .pm module with your favorite text editor 2. Add 'use Koha::I18N;' in the beginning of file 3. Use one of the subroutines exported by Koha::I18N and be sure to have a way to visualize the result (pass result to the template for example, or simply warn and watch the log file) 4. cd misc/translator && ./translate update fr-FR # try other languages 5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your string(s) You will need to change the "Plural-Forms" header. See https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct Example usage: __("Hi") __x("Hi {name}", name => 'Bob') __n("item", "items", $num_items) __nx("one item", "{count} items", $num_items, count => $num_items) __p("Bibliographic record", "item") -- You are receiving this mail because: You are watching all bug changes.

1 0