April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14974] Use the REST API for cities
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from Julian Maurice <julian.maurice(a)biblibre.com> --- No AngularJS/SomethingElseJS proposal so far, so I suggest we move forward with this. Changing status to Needs signoff to have more opinions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14974] Use the REST API for cities
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 --- Comment #8 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50022&action=ed… Bug 14974: Try to make benefit from using the API Previous patch immediately redirect after each action (add/edit/delete) so there is no real benefit from using the API. This patch move the add/edit form into a modal window, and redraw the table after each action, so the page is never reloaded. It also adds a messages area to put messages in (after success/error) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16192] New: Coverage reports missing
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16192 Bug ID: 16192 Summary: Coverage reports missing Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Continuous Integration Assignee: tomascohen(a)gmail.com Reporter: tomascohen(a)gmail.com After the server move, the tests don't show the clover coverage report. They should be re-configured. -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel(a)gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Applying: Bug 15395: Example usage of I18N Template::Toolkit plugin Using index info to reconstruct a base tree... M C4/Search.pm M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth(a)kul.oslo.k | |ommune.no --- Comment #11 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Rebased against #15548 Move Koha::Borrower -> Koha::Patron Works fine in API, but tests fail: not ok 23 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/checkouts.t line 119. # got: '500' # expected: '200' not ok 24 - exact match for JSON Pointer "/date_due" # Failed test 'exact match for JSON Pointer "/date_due"' # at t/db_dependent/api/v1/checkouts.t line 119. # got: undef # expected: '2016-04-14 23:59:00' ok 25 - PUT /api/v1/checkouts/6 not ok 26 - 403 Forbidden # Failed test '403 Forbidden' # at t/db_dependent/api/v1/checkouts.t line 125. # got: '500' # expected: '403' not ok 27 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/checkouts.t line 125. # Structures begin differing at: # $got = undef # $expected = HASH(0xa7d1648) # Looks like you failed 4 tests of 27. Relevant log entry: No branchcode argument passed to Koha::Calendar->new at /kohadev/kohaclone/C4/Circulation.pm line 3588 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45817|0 |1 is obsolete| | --- Comment #10 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 50021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50021&action=ed… Bug 13895: Add API routes for checkouts retrieval and renewal GET /checkouts?borrowernumber={borrowernumber} GET /checkouts/{checkout_id} PUT /checkouts/{checkout_id} + unit tests in t/db_dependent/api/v1/checkouts.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with a borrowernumber that has checkouts) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error) 5. Run unit tests in t/db_dependent/api/v1/checkouts.t Depends on bug 15126 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11904] Proposal for a uniform way to send messages to user interface
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #55 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #54) > I personally do not like the idea to move the strings to the pl scripts. Why ? :) I sometimes feel that extra effort is put into moving strings to template file (and we do this only because that's the only place where they can be translated) > Moreover we have tried to use the KohaDates plugin as much as possible in > template files, which you are reverting with this patch. I don't understand why this is an issue, the message is now in .pl script so the date formatting happens here. It seems logical. Note that moving message from .tt to .pl is not the main purpose of this bug, if you have another solution in mind I will gladly hear it :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11904] Proposal for a uniform way to send messages to user interface
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #54 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I personally do not like the idea to move the strings to the pl scripts. Moreover we have tried to use the KohaDates plugin as much as possible in template files, which you are reverting with this patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50004|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50019&action=ed… Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled This patch changes the behaviour of the koha-rebuild-zebra script in the following way: USE_INDEXER_DAEMON=no - Keeps the current behaviour USE_INDEXER_DAEMON=yes - It skips incremental indexing to avoid races. Caveats: - A --force option is introduced for useing in a specific situtation that might need it (i.e. the administrator knows what he's doing). - If --full is passed, the reindexing is not skipped. The documentation files and messages are adjusted accordingly. This patch should help users that want to use the indexing daemon, in which case they wouldn't need to change their default 5 min cronjob (it will be just skipped). Ultimately, koha-common could have USE_INDEXER_DAEMON = yes by default, but that's subject for another bug report. To test: - Play with the different option switches and USE_INDEXER_DAEMON - Things work as expected - Sign off Regards Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as expected Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '16

07 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0