April 2016 - Koha-bugs - lists.koha-community.org

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com --- Comment #9 from Nick Clemens <nick(a)bywatersolutions.com> --- I added a follow up to display the information on the message box before a hold is confirmed, but only if no transfer is required -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #8 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 49940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49940&action=ed… Bug 9543 - Show patrons messaging subscription on holds notification not already waiting Same plan as previous patch, but this one should show the message for a hold not already waiting but not requiring a transfer (hold-found2 alert box) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49533|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 49939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49939&action=ed… Bug 9543 - Show patrons messaging subscription on holds notification Display an information about a patron's messaging preferences if an item is checked in where the patron has put a hold. To test: - Apply patch - Make sure that SMS driver and TalkingTech sysprefs are defined to enable SMS and Phone preferences for users (SMS driver can be a dummy value) - Place a hold for a patron - Set patron's messaging preferences to different choices (including none) - Check in the item that is on hold (it has not to be checked out for the test - Verify that below the message "Hold found (item is already waiting") an information appears about the patron's messaging preferences. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2324] Undo Import should have a confirm dialog
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49717|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 49938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49938&action=ed… Bug 2324: Adding confirm dialog when undoing import EDIT: Comment 3 To test: 1) Go to Tools -> Staged MARC Management 2) Click on a batch to see details 3) If not already imported, then import, otherwise you should already see the button to undo import into catalog. 4) Click this button. Confirm you are asked to confirm. Confirm clicking Cancel will cancel the undo. Confirm clicking OK will continue with the undo. Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2324] Undo Import should have a confirm dialog
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13438] Convert normarc framework plugins to new style (see also 10480)
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 --- Comment #4 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 49823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49823 Bug 13438: Convert normarc framework plugins to new style Review of attachment 49823: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=134…) ----------------------------------------------------------------- ::: cataloguing/value_builder/normarc_field_007.pl @@ +88,1 @@ > #FIXME: There is probably a more-elegant way to do this! You mean something like: use Data::Dumper; my $str='abcdef'; my $len=22-length $str; @tmp = split //,$str; push @tmp,(undef)x($len); print Dumper(\@tmp);" And some sort of my @field_numbers = map { "f$_" } (0..21); Then use a loop to template->param it all? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #99 from Nick Clemens <nick(a)bywatersolutions.com> --- Simple conflict in Letters.pm but then: Applying: Bug 8000 - Correct inability to know where message was sent fatal: sha1 information is lacking or useless (t/db_dependent/Letters.t). If rebased I will try to test quickly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '16

06 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #23 from M. Tompsett <mtompset(a)hotmail.com> --- Nick signed off the first one, but didn't obsolete it. I did, these apply. However, now I get: mtompset@debian:~/kohaclone$ prove t/db_dependent/Serials.t t/db_dependent/Serials.t .. 1/46 No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. t/db_dependent/Serials.t .. ok All tests successful. Files=1, Tests=46, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.13 cusr 0.02 csys = 1.17 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

1 0