April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45673|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 49919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49919&action=ed… Bug 14305: View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * '<a href="?branch=BRANCH1">BRANCH1</a>' * '<a href="?branch=">none</a>' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library http://bugs.koha-community.org/show_bug.cgi?id=14305 Changed 2015-12-14: Whitespace fix Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41639|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 49918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49918&action=ed… Bug 14305: View arbitrary branch's news, RSS fix This fix changes the RSS link to reflect the URL paramter override. This is less elegant than the existing solution which uses the Branches TT module, perhaps there is a better way? Sponsored-By: Halland County Library Test plan: * Follow instructions in the original patch but also check the URLs and contents of the RSS link at the bottom the OPAC page. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15630] Make Edifact module pluggable
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #10 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- *Manually added in the missing updatedatabase.pl for .plugin -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #8 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 49917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49917&action=ed… Bug 14305: RSS message correction follow-up If a user is not logged in but requests a specific branch, the RSS feed message fails to mention the branch. TEST PLAN --------- 1) Apply first two patches 2) go to OPAC's opac-main.pl?branch={some branch with specific news} -- notice bad RSS message 3) Apply this patch 4) Repeat step 2 -- notice branch is properly shown. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan(a)bywatersolutions.co | |m --- Comment #15 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5158] Koha needs its own cookie, ice cream, and fudge flavors
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com --- Comment #5 from Nick Clemens <nick(a)bywatersolutions.com> --- These sound terrible, but taste amazing: http://realhousemoms.com/starburst-jelly-bean-cookies/ -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5979] Add separate OPACISBD system preference
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #41 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Katrin Fischer from comment #40) > Maybe this should be an enh? I agree, because it adds a new system preference. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14755] Checking in gives error 500
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '16

05 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard(a)myacpl.org |xarragon(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0