April 2016 - Koha-bugs - lists.koha-community.org

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49596|0 |1 is obsolete| | Attachment #49597|0 |1 is obsolete| | Attachment #49607|0 |1 is obsolete| | Attachment #49740|0 |1 is obsolete| | Attachment #49741|0 |1 is obsolete| | --- Comment #84 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49766&action=ed… [PASSED QA] Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches but now adds a patron_list_id parameter to C4::Members::GetBorrowersToExpunge and uses that routine to fetch patrons from a list. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table 5) Verify previous functionality has not changed Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Patron batches are correctly passed to the edit and delete pages. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #11 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 49716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49716 Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar Review of attachment 49716: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=366…) ----------------------------------------------------------------- ::: circ/add_message.pl @@ +51,4 @@ > } > )->store; > > +my $url = $input->referer(); http://perldoc.perl.org/CGI.html "referer() Return the URL of the page the browser was viewing prior to fetching your script. Not available for all browsers." -- might be a good idea to // "/cgi...$borrowernumber"; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1750] Report bor_issues_top erroneous and truncated results.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com URL|http://staff-atz.dev.kohali | |brary.com/cgi-bin/koha/repo | |rts/bor_issues_top.pl | --- Comment #9 from M. Tompsett <mtompset(a)hotmail.com> --- URL deleted as it links to the WRONG location. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1750] Report bor_issues_top erroneous and truncated results.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49762|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 49763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49763&action=ed… Bug 1750 - Report bor_issues_top erroneous and truncated results. Signed-off-by: Mason James <mtj(a)kohaaloha.com> TEST PLAN --------- 1) Ensure you have some checkouts 2) Home -> Reports -> Patrons with the most checkouts 3) Click 'Submit' -- you get a list 4) Click a patron name. 5) Note the borrower number. 6) In MySQL run something like: > UPDATE borrower SET firstname=NULL WHERE borrowernumber=#### 7) Refresh the report page -- name goes totally blank 8) apply patch 9) Refresh the report page -- only first name is lost 10) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1750] Report bor_issues_top erroneous and truncated results.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1750] Report bor_issues_top erroneous and truncated results.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 --- Comment #7 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 49762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49762 Bug 1750 - Report bor_issues_top erroneous and truncated results. Review of attachment 49762: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=175…) ----------------------------------------------------------------- ::: reports/bor_issues_top.pl @@ +279,4 @@ > my $strcalc ; > > # Processing average loanperiods > + $strcalc .= "SELECT CONCAT_WS('', borrowers.surname , \",\\t\", borrowers.firstname), COUNT(*) AS RANK, borrowers.borrowernumber AS ID"; http://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_conca… Nice! CONCAT_WS skips NULL entries, but still concat's, while CONCAT gives up and returns NULL. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1750] Report bor_issues_top erroneous and truncated results.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16184 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 [Bug 16184] Report bor_issues_top shows incorrect number of rows -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1750] Report bor_issues_top erroneous and truncated results.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 [Bug 16184] Report bor_issues_top shows incorrect number of rows -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1750] Report bor_issues_top erroneous and truncated results.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49758|0 |1 is obsolete| | --- Comment #6 from Mason James <mtj(a)kohaaloha.com> --- Created attachment 49762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49762&action=ed… Bug 1750 - Report bor_issues_top erroneous and truncated results. Signed-off-by: Mason James <mtj(a)kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

1 0