April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #18 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Comment on attachment 44373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44373 Bug 15126: x-mojo-controller deprecation >From a1267ff354633ef7f491704f81d9ffe1590672a7 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> >Date: Wed, 7 Oct 2015 14:49:17 +0000 >Subject: [PATCH] Bug 15126: x-mojo-controller deprecation > >Remove the use of soon to be deprecated x-mojo-controller from our >specification and replace with the recommended operationId format. >--- > Koha/REST/V1/{Patrons.pm => Patron.pm} | 6 +++--- > api/v1/swagger.json | 2 -- > 2 files changed, 3 insertions(+), 5 deletions(-) > rename Koha/REST/V1/{Patrons.pm => Patron.pm} (96%) > >diff --git a/Koha/REST/V1/Patrons.pm b/Koha/REST/V1/Patron.pm >similarity index 96% >rename from Koha/REST/V1/Patrons.pm >rename to Koha/REST/V1/Patron.pm >index 6468bba..fee6c31 100644 >--- a/Koha/REST/V1/Patrons.pm >+++ b/Koha/REST/V1/Patron.pm >@@ -1,4 +1,4 @@ >-package Koha::REST::V1::Patrons; >+package Koha::REST::V1::Patron; > > # This file is part of Koha. > # >@@ -22,7 +22,7 @@ use Mojo::Base 'Mojolicious::Controller'; > use C4::Auth qw( haspermission ); > use Koha::Patrons; > >-sub list_patrons { >+sub list { > my ($c, $args, $cb) = @_; > > my $user = $c->stash('koha.user'); >@@ -35,7 +35,7 @@ sub list_patrons { > $c->$cb($patrons->unblessed, 200); > } > >-sub get_patron { >+sub get { > my ($c, $args, $cb) = @_; > > my $user = $c->stash('koha.user'); >diff --git a/api/v1/swagger.json b/api/v1/swagger.json >index 8f32781..e821c44 100644 >--- a/api/v1/swagger.json >+++ b/api/v1/swagger.json >@@ -16,7 +16,6 @@ > "paths": { > "/patrons": { > "get": { >- "x-mojo-controller": "Koha::REST::V1::Patrons", > "operationId": "listPatrons", > "tags": ["patrons"], > "produces": [ >@@ -43,7 +42,6 @@ > }, > "/patrons/{borrowernumber}": { > "get": { >- "x-mojo-controller": "Koha::REST::V1::Patrons", > "operationId": "getPatron", > "tags": ["patrons"], > "parameters": [ >-- >1.9.1 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #15 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #13) > So I am not convinced that we should move it. But if you really insist, I'd > rather move it to Upload.pm or so? No reply is also an answer. Jesse: I moved it. Please finish QA now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49780&action=ed… Bug 14686: [QA Follow-up] Move allows_add_by to Upload.pm As requested by QA, the sub should be moved. Test plan: See previous patches. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16146] New: ACQ: Previewed records in Z39.50 search results are wrong
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Bug ID: 16146 Summary: ACQ: Previewed records in Z39.50 search results are wrong Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: christian.stelzenmueller(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When searching for records via Z39.50 in Aquisitions the context menu links display the wrong records (probably the last one on the list). This was fixed by bug 15318 on master. But not backported as it is an enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 15630] Make Edifact module pluggable
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #88 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49770&action=ed… [PASSED QA] Bug 10612: (QA followup) Rename not_borrowered_since to not_borrowed_since Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #87 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49769&action=ed… [PASSED QA] Bug 10612 - Unit tests Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #86 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49768&action=ed… [PASSED QA] Bug 10612: Follow-up - correcting icon to be Font Awesome - check print icon on the patron list summary page is correct Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #85 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 49767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49767&action=ed… [PASSED QA] Bug 10612 [Follow-up] Combine and clarify menu items This follow-up patch for Bug 10612 moves all list operations into one menu while (hopefully) clarifying the labels for each. Also in this patch: Changed datatables sorting configuration to use the "nosort" attribute. To test, apply the patch and go to Tools -> Patron lists. - On a patron list with no patrons, confirm that the "Actions" menu lists "Add patrons," "Edit list," and "Delete list." - On a patron list containing one or more patrons, confirm that the "Actions" menu /also/ has these options: "Print patron cards," "Batch edit patrons," and "Batch delete patrons." - Confirm that the "actions" column is not sortable. - Test logging in as a user who has various combinations of permission to batch edit and batch delete. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0