April 2016 - Koha-bugs - lists.koha-community.org

[Bug 11088] Patron entry page should use floating toolbar like cataloging interface
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50925|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 50936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50936&action=ed… [SIGNED-OFF] Bug 11088 [Follow up] - Patron entry page should use floating toolbar like cataloging interface To test: 1) Go to add a new patron 2) Confirm floating 'Save' button stays fixed at bottom right corner of the page as you scroll the page up/down 3) Resize the browser window to s smaller size, and see the 'Save' button stays fixed in place 3) Go to edit an existing patron 4) Repeat Step 2 and 3 Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11088] Patron entry page should use floating toolbar like cataloging interface
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50878|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 50935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50935&action=ed… [SIGNED-OFF] Bug 11088: Floating Save div for Patron entry page To test: 1) Go to add a new patron 2) Confirm floating save div scrolls down page with you and works as expected 3) Go to edit an existing patron 4) Repeat Step 2 Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11088] Patron entry page should use floating toolbar like cataloging interface
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This is not yet ready (see last comment): Set noissuescharge to 0, I cannot checkout: 120NUN20160428 194310AORMA|AA2|AB123|AJMastering Perl /|AH|AFPatron Blocked|BLY| Note: CanBookBeIssued does checks like $non_issue_charges > $amountlimit==noissuescharge This is not exactly the same as: $fines_amount < C4::Context->preference('noissuescharge') Similarly, opac-user checks the renewal amount like: defined($no_renewal_amt) && $borr->{amountoutstanding} > $no_renewal_amt Different than just $fines_amount < C4::Context->preference('OPACFineNoRenewals') BTW Found this sql in Members.pm: $sth = $dbh->prepare("SELECT SUM(amountoutstanding) FROM accountlines WHERE borrowernumber = ?"); This is actually the same as GetTotalFines does. Are we using this more? Should we add a (simple) unit test for the new routine? Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #58 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- There are some complaints from the QA script, I can take care of the tabs, but not sure about the last complaint: FAIL reports/cash_register_stats.pl OK critic FAIL forbidden patterns forbidden pattern: tab char (line 176) forbidden pattern: tab char (line 159) forbidden pattern: tab char (line 162) forbidden pattern: tab char (line 160) forbidden pattern: tab char (line 156) forbidden pattern: tab char (line 163) forbidden pattern: tab char (line 179) forbidden pattern: tab char (line 178) forbidden pattern: tab char (line 157) forbidden pattern: tab char (line 180) forbidden pattern: tab char (line 164) forbidden pattern: tab char (line 174) forbidden pattern: tab char (line 181) forbidden pattern: tab char (line 177) forbidden pattern: tab char (line 158) forbidden pattern: tab char (line 171) forbidden pattern: tab char (line 161) forbidden pattern: tab char (line 175) OK pod OK spelling 0 FAIL valid Useless use of hash element in void context -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11326] show more facets should not reload search
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |nick(a)bywatersolutions.com --- Comment #1 from Nick Clemens <nick(a)bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 14419 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14419] Expanding facets (Show more) performs a new search
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro(a)gmail.com --- Comment #5 from Nick Clemens <nick(a)bywatersolutions.com> --- *** Bug 11326 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15533] Allow patrons and librarians to select itemtype when placing hold
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- On a positive note: holds are not triggered for the wrong itemtype, but are triggered for the correct one. Setting holds with the pref off still works as expected. Kyle, can you please take a look at the last 2 comments? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15533] Allow patrons and librarians to select itemtype when placing hold
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 --- Comment #21 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Another thing: The requested itemtype is perfectly visible in the patron account in the OPAC, but not on the holds summary page of the record nor in the patron account in staff (Checkouts and detail tabs) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15533] Allow patrons and librarians to select itemtype when placing hold
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Found a problem: When placing multiple holds at once from the result list, the itemtype list is not correct - It seems to show the itemtypes from the first record. This allows you to place 'unfillable' holds - as there are no items of this itemtype on the other records necessarily. -- You are receiving this mail because: You are watching all bug changes.

1 0